fix: instantiate Result with new in resultWrapper#390
Open
achromik wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Since 3.18.0 (taxonomy support release),
src/core/modules/result.jsexportsResultas an ES class — previously it exported a factory function (module.exports = function (object) { return new Result(object); }). However,resultWrapper()insrc/core/lib/utils.jsstill invokesResult(...)as a plain function in 5 places.Any success response going through
resultWrapper— e.g.Stack.ContentType(...).Entry(uid).fetch()without.toJSON()— throws:This is a regression introduced in 3.18.0 — versions <= 3.17.2 are unaffected.
Repro (offline, >= 3.24.0 where the SDK uses global fetch)
For 3.18.0–3.23.x the same failure reproduces with
node-fetchstubbed instead ofglobal.fetch(those versions use thenode-fetchdependency).Fix
Add the missing
newkeyword at the 5Result(...)call sites inresultWrapper().Verified by applying the equivalent change to the built
dist/node/contentstack.jsand re-running the repro above — the entry resolves correctly.