Skip to content

feat: Added TOTP support login command and version bump#2049

Closed
cs-raj wants to merge 43 commits into
developmentfrom
feat/DX-3412
Closed

feat: Added TOTP support login command and version bump#2049
cs-raj wants to merge 43 commits into
developmentfrom
feat/DX-3412

Conversation

@cs-raj
Copy link
Copy Markdown
Contributor

@cs-raj cs-raj commented Aug 7, 2025

version bump:
@contentstack/cli-auth: 1.5.1 -> 1.6.0
@contentstack/cli-cm-export: 1.18.0 -> 1.18.1

@cs-raj cs-raj requested a review from aman19K August 7, 2025 12:50
aman19K
aman19K reviewed Aug 8, 2025
View reviewed changes
Comment thread packages/contentstack-auth/src/commands/auth/login.ts Outdated
aman19K
aman19K suggested changes Aug 8, 2025
View reviewed changes
Comment thread packages/contentstack-auth/src/utils/auth-handler.ts Outdated
Comment thread packages/contentstack-auth/src/utils/interactive.ts Outdated
Comment thread packages/contentstack/package.json Outdated
Comment thread packages/contentstack-auth/src/utils/totp-handler.ts Outdated
Comment thread packages/contentstack-auth/src/utils/totp-handler.ts Outdated
Comment thread packages/contentstack-auth/src/utils/totp-handler.ts Outdated
Comment thread packages/contentstack-auth/src/utils/totp-handler.ts Outdated
Comment thread packages/contentstack-auth/src/utils/totp-handler.ts Outdated
kaustubh-CS
kaustubh-CS previously approved these changes Aug 8, 2025
View reviewed changes
@cs-raj cs-raj changed the base branch from feat/DX-3362 to staging August 8, 2025 09:43
@cs-raj cs-raj dismissed kaustubh-CS’s stale review August 8, 2025 09:43

The base branch was changed.

netrajpatel
netrajpatel previously approved these changes Aug 8, 2025
View reviewed changes
aman19K
aman19K reviewed Aug 14, 2025
View reviewed changes
Comment thread packages/contentstack-export/package.json
aman19K
aman19K reviewed Aug 14, 2025
View reviewed changes
Comment thread packages/contentstack-config/src/services/mfa/mfa.service.ts Outdated
aman19K
aman19K reviewed Aug 14, 2025
View reviewed changes
Comment thread packages/contentstack-config/src/commands/config/mfa/remove.ts Outdated
aman19K
aman19K reviewed Aug 14, 2025
View reviewed changes
Comment thread packages/contentstack-config/src/commands/config/mfa/add.ts Outdated
aman19K
aman19K reviewed Aug 14, 2025
View reviewed changes
Comment thread packages/contentstack-config/src/commands/config/mfa/remove.ts Outdated
aman19K
aman19K reviewed Aug 14, 2025
View reviewed changes
Comment thread packages/contentstack-config/src/commands/config/mfa/add.ts Outdated
aman19K
aman19K reviewed Aug 14, 2025
View reviewed changes
Comment thread packages/contentstack-config/src/commands/config/mfa/add.ts Outdated
aman19K
aman19K reviewed Aug 14, 2025
View reviewed changes
Comment thread packages/contentstack-config/src/commands/config/mfa/add.ts Outdated
aman19K
aman19K reviewed Aug 14, 2025
View reviewed changes
Comment thread packages/contentstack-auth/src/utils/mfa-handler.ts Outdated
aman19K
aman19K reviewed Aug 14, 2025
View reviewed changes
Comment thread packages/contentstack-auth/src/utils/mfa-handler.ts Outdated
aman19K
aman19K reviewed Aug 14, 2025
View reviewed changes
Comment thread packages/contentstack-auth/src/utils/mfa-handler.ts Outdated
aman19K
aman19K reviewed Aug 14, 2025
View reviewed changes
Comment thread packages/contentstack-auth/src/utils/auth-handler.ts Outdated
aman19K
aman19K reviewed Aug 14, 2025
View reviewed changes
Comment thread packages/contentstack-auth/src/utils/auth-handler.ts Outdated
aman19K
aman19K reviewed Aug 14, 2025
View reviewed changes
Comment thread packages/contentstack-auth/src/utils/auth-handler.ts Outdated
aman19K
aman19K reviewed Aug 14, 2025
View reviewed changes
Comment thread packages/contentstack-auth/src/utils/auth-handler.ts Outdated
aman19K
aman19K reviewed Aug 14, 2025
View reviewed changes
Comment thread package.json Outdated
shafeeqd959
shafeeqd959 reviewed Aug 14, 2025
View reviewed changes
Comment thread package.json Outdated
Comment thread packages/contentstack-auth/src/commands/auth/login.ts
Comment thread packages/contentstack-auth/src/utils/auth-handler.ts Outdated
Comment thread packages/contentstack-auth/src/utils/auth-handler.ts Outdated
Comment thread packages/contentstack-auth/src/utils/auth-handler.ts Outdated
Comment thread packages/contentstack-config/src/commands/config/mfa/add.ts Outdated
Comment thread packages/contentstack-config/src/commands/config/mfa/remove.ts Outdated
Comment thread packages/contentstack-config/src/commands/config/mfa/remove.ts Outdated
Comment thread packages/contentstack-config/src/commands/config/set/region.ts
Comment thread packages/contentstack-config/src/services/mfa/mfa-service.interface.ts
@cs-raj
Copy link
Copy Markdown
Contributor Author

cs-raj commented Sep 19, 2025

Closing the PR since this contained changes across more 2 plugins and had 3 different commands.
The Support for login has been added in a different PR
cc: @netrajpatel @aman19K

@cs-raj cs-raj closed this Sep 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shafeeqd959 shafeeqd959 shafeeqd959 left review comments

@netrajpatel netrajpatel Awaiting requested review from netrajpatel

+2 more reviewers

@aman19K aman19K aman19K requested changes

@kaustubh-CS kaustubh-CS kaustubh-CS left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@cs-raj @shafeeqd959 @netrajpatel @kaustubh-CS @aman19K