Add stdin detach/re-attach coverage#7
Open
dmcgowan wants to merge 1 commit into
Open
Conversation
Add a StdinDetachReattach conformance test verifying that closing a client's stdin write end without CloseIO does not deliver EOF, and that only CloseIO delivers it, allowing detach and later re-attach. Fix testOutboundTCP, testOutboundUDP, and the stress exec round-trip helper to issue CloseIO for stdin EOF instead of relying on the client's own FIFO/pipe write end closing alone, and fix ordering so the Windows stdin pipe listener is accepting before Create/Exec dials it. Signed-off-by: Derek McGowan <derek@mcg.dev>
|
Is this test failure because nerdbox is actually non-conformant? Are you tracking a fix for that? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a StdinDetachReattach conformance test verifying that closing a client's stdin write end without CloseIO does not deliver EOF, and that only CloseIO delivers it, allowing detach and later re-attach.
Fix testOutboundTCP, testOutboundUDP, and the stress exec round-trip helper to issue CloseIO for stdin EOF instead of relying on the client's own FIFO/pipe write end closing alone, and fix ordering so the Windows stdin pipe listener is accepting before Create/Exec dials it.