fix: preserve equals signs in image label filter values - #5163
Open
immanuwell wants to merge 1 commit into
Open
Conversation
Signed-off-by: Immanuel Tikhonov <pchpr.00@list.ru>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
nerdctl images --filter label=example.payload=a=bfails withinvalid filter, while Docker accepts the same filter.Label values are plain strings, so
=is legit hereThe parser now splits into at most three parts and keeps the rest in the label value.
Non-label filters keep their old validation
Repro before this change:
nerdctl images --filter label=example.payload=a=bFATA[0000] invalid filter "label=example.payload=a=b"Tested with
go test ./pkg/imgutil ./pkg/cmd/image