Skip to content

Add volume health proposal#604

Open
gnufied wants to merge 5 commits into
container-storage-interface:masterfrom
gnufied:implement-volume-health
Open

Add volume health proposal#604
gnufied wants to merge 5 commits into
container-storage-interface:masterfrom
gnufied:implement-volume-health

Conversation

@gnufied
Copy link
Copy Markdown
Contributor

@gnufied gnufied commented May 21, 2026

No description provided.

@gnufied gnufied changed the title {WIP} Add volume health proposal Add volume health proposal May 26, 2026
@gnufied gnufied force-pushed the implement-volume-health branch 2 times, most recently from ee77999 to 8789044 Compare May 28, 2026 20:25
@gnufied gnufied force-pushed the implement-volume-health branch from 8789044 to 456214c Compare May 28, 2026 21:06
Comment thread spec.md
message ListVolumesResponse {
message VolumeStatus{
reserved 2;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wondered if removing the volume_condition field (and others) causes compatibility issues. It seems that using the reserved notation addresses my concerns.

👍

Comment thread spec.md
message NodeGetStorageHealthResponse {
option (alpha_message) = true;

message StorageBackendHealth {
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is actually something that could be provided by the controller too. Network storage clusters (like Ceph) can return their health with sufficient parameters and secrets. If the backend storage is unhealthy, there probably is little reason to attempt to use it for new volumes, or expect (fully) functional usage by the nodeplugin.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was thinking about this use case, but where would we report it? In CSIDriver object? I do not think, CSI driver object was designed for such use case, but idea is sound in theory.

I am intentionally keeping some of the health reporting as future enhancement, so as we can ship something rather than being bogged down by designing everything upfront. I am adding a section in kubernetes/enhancements#6138 to keep track of future enhancements. I will update

@nixpanic
Copy link
Copy Markdown
Contributor

nixpanic commented Jun 4, 2026 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants