fix(desktop): recover the embedded laser view when a project switch restarts the brain - #99
Merged
Merged
Conversation
…estarts the brain
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Switching projects while on Show left the embedded artist UI a black rectangle until the app was reloaded. It isn't z-index: the native
WebContentsViewwas still there, sitting on a load that never completed.Two causes, one shape — nothing ever asked again:
invalidateLaserView()fires the reload right after the brain restarts. If that load fails (server not listening yet, or it is aborted by alaser:syncload racing it), the URL gate is cleared but the renderer has no reason to send another sync, so no code path retries.setVisible(true)regardless, so the failure showed as black rather than as the route's own empty state.So the view now tracks desired vs loaded separately and heals itself:
Leaving Show (
syncLaser({visible:false})) clearsdesiredUrl, which cancels the pending retry — a backoff that outlives the screen it belongs to is the next bug. Each load takes aloadSeq, so theERR_ABORTEDrejection of a superseded load can't schedule a retry over the load that replaced it.__tests__/laser-view.test.tscovers this against a mockedelectron: paint-then-show, retry after a failed load, backoff growth, cancellation on leaving Show, reload on project switch, and no reload for an unchanged URL. Four of the six fail against the previous implementation.Link to Devin session: https://app.devin.ai/sessions/972698f89f494b86828010666a002b8f
Requested by: @pyramation