fix(desktop): centre the brand and project tiles on the collapsed icon rail - #98
Merged
Conversation
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
On the collapsed rail the Wavegrid logo and the project switcher sat right of every nav icon — measured in the DOM, their glyph centres were at x=32 against the nav icons' x=24.
Both are
size='lg'sidebar buttons, and that variant's collapsedp-0!never applies: it and the basegroup-data-[collapsible=icon]:p-2!both survivecn()(thistailwind-mergedoesn't treat Tailwind v4's trailing-!important syntax as a conflict), sop-2wins on stylesheet order. That leaves a 16px content box holding a 32px tile, which overflows to the right by exactly the padding.Rather than fight the merge, the tile is pulled back by that padding when collapsed, and the label/chevron — which have no room on a 48px rail anyway — are hidden:
Verified by rendering the shell against a throwaway Vite entry and reading
getBoundingClientRect()for every sidebar icon: all eleven now centre at x=24. Expanded layout is unchanged.Link to Devin session: https://app.devin.ai/sessions/972698f89f494b86828010666a002b8f
Requested by: @pyramation