feat(desktop): group the sidebar by Run / Set up / Advanced behind one project switcher - #97
Merged
Merged
Conversation
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Nine flat nav items made "Show" and "Users & Secrets" look equally likely to be the thing you want. The sidebar is now grouped by when you reach for something, with the current project chosen once at the top:
Config→Layout,Users & Secrets→People & Keys.Projectsstops being a nav destination: the switcher owns choosing one and links to "Manage projects…", which is closer to how it actually works — you don't visit projects, you're in one.The substantive change under the cosmetics is that there is now exactly one current project.
configProject(the project a row's "Config" button pinned for editing) is gone, soeditingProject === activeProjectalways. Previously the screen and the stage could disagree about which project you were changing, which is the same class of bug as the stale Lights panel and the dead session.That makes switching a real action, so every path to it funnels through one guard rather than each button deciding for itself:
Both the switcher and the Projects screen (
onUse, andonEditConfig, which now switches then opens Layout) go through it.The nav model moved out of
App.tsxintorenderer/lib/navigation.tsso it can be asserted on:navigation.test.tsfails if a route is added that appears in no group and isn't explicitly listed as switcher-reachable — the flat list had no such guard, and a route that exists but is unreachable looks exactly like a broken build.AppShellgains one additive prop,sidebarHeader, rendered under the brand; no existing usage changes.pnpm test,pnpm build,pnpm lintpass.Link to Devin session: https://app.devin.ai/sessions/972698f89f494b86828010666a002b8f
Requested by: @pyramation