fix(desktop): make user delete work, refetch every panel on a project change - #94
Merged
Merged
Conversation
Deleting a user did nothing in the most common case: the trash button was
disabled for the only admin, which in a one-user project is the only row
there is. The store allows it (removing the last account just disables UI
logins) — only losing the last admin *while other users remain* is a
lock-out. The rule now lives in one place both the store and the UI agree
on, and rejected store writes are shown instead of being swallowed by an
unhandled promise rejection.
Panels also refetched on the project *name* only, so switching the project
in use — or importing over it, or clearing the store — could leave a panel
showing what it fetched on mount. Every project-scoped hook now takes a
ProjectScope { project, rev }, and rev is bumped whenever the store
changes underneath the panels.
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Delete did nothing because the button was disabled. The Users tab blocked removal for the only admin — which, in a one-user project, is the only row there is. The store's rule is narrower: losing the last admin is only a lock-out while other users remain; removing the very last account is allowed (it just disables UI logins, and is undone by adding a user). The two rules now come from one place:
And a refused write is no longer invisible: every
runAction(...)failure lands in a dismissible banner, where beforevoid withBusy(...)turned a store rejection into an unhandled promise rejection and a button that looked dead.Panels kept mount-time data. Each project-scoped hook refetched on the project name, so nothing refetched when the contents changed underneath the same name — switching the project in use, importing over a project, clear-all:
Appholds onedataRevand hands outactiveScope/editingScope, bumping it on use / create / remove / import / clear. That's the general version of the fix in #92, which only cleared the pinned config project and restarted the brain.Link to Devin session: https://app.devin.ai/sessions/972698f89f494b86828010666a002b8f
Requested by: @pyramation