sync: port the capabilities rename and five modules' drift from constructive-db - #119
Merged
Merged
Conversation
…ructive-db constructive-db vendors these modules and edits them in place, so the two trees drift until someone ports the changes back (last done in #118). Five modules had substantive drift; the other 25 differ only in the test harness import and bundle artifacts. metaschema-modules carries the rename: permissions_module becomes capabilities_module and data_permissions_field becomes data_capabilities_field, default_permissions becomes default_capabilities on every module table that has it, plus four module tables the platform already provisions (content_preset, email_sender, oauth_requests, file_ref_field). function-resolution gains the opt-in staging bucket (resolve_staging_bucket, staging_bucket_tag). metaschema-schema, object-store and object-tree carry procedure-level fixes. Tests keep upstream's pgsql-test import rather than the vendored constructive-test one. sql/ artifacts regenerated with pgpm package 5.23.1; metaschema-modules snapshots re-recorded against the ported deploy tree. A publish needs a version bump: 0.40.0 is already released and these changes rename objects inside it.
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
…ex name app-scope's membership test still inserted permissions_table_id / default_permissions_table_id into memberships_module, which the ported metaschema-modules renamed; constructive-db's copy of that test was already updated. Also renames data_capabilities_field's index, which still carried permissions_module in its name.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
constructive-dbvendors these modules underpgpm-modules/and edits them in place, so the trees drift until someone ports back (last done in #118). This is that port, driven by the platform rename ofpermissions→capabilities.I diffed all 30 vendored modules against
packages/. Only five have substantive drift; the other 25 differ solely in the test harness import (constructive-testvspgsql-test) and in bundle artifacts, so they are untouched here.metaschema-modules — the rename, and it is a rename in place, not an append-only change:
The four added tables are modules
provision_database_modulesalready accepts; they were only missing here.function-resolution — the opt-in staging bucket:
resolve_staging_bucket+staging_bucket_tagchanges and the correspondingresolve_apiupdate.metaschema-schema / object-store / object-tree — procedure-level fixes (
enforce_api_exposure_ratchet,object_category,insert_nodes_at_paths,init_empty_repo,set_and_commit,set_many_and_commit).Notes for review:
import { ... } from 'pgsql-test'— the vendoredconstructive-testimport is not upstreamed.sql/*.sqlandsql/*.bundle.tar.gzregenerated withpgpm packageon 5.23.1 (5.8.0 resolves inside the workspace and silently emits no bundle — it deletes the artifact).metaschema-modulessnapshots re-recorded against the ported deploy tree (68 → 71 module tables, 486 → 505 FK constraints). The vendored snapshot was itself stale, so it was not copied verbatim.0.40.0is already released and this changes object names inside it.Verified locally against
constructiveio/postgres-plus:18: function-resolution 83/83, object-store 28/28, object-tree 15/15, metaschema-schema 1/1, metaschema-modules 8/8.Not ported, flagging instead:
constructive-dbalso vendors two modules that do not exist here at all —@pgpm/db-utilsand@pgpm/infra-utils, both0.0.1. They look deliberately platform-local; say the word if they belong upstream.Link to Devin session: https://app.devin.ai/sessions/8f89acc9280e4cef880921d966e0e8fc
Requested by: @pyramation