ci: make package test failures fail the build, cover four untested packages - #117
Merged
Conversation
…ckages The test job carried continue-on-error: true, so a red package test reported as a failed check but left the workflow green — the object-tree verify/revert signature bug reached main that way. The matrix also skipped every package with tests that was added after it was written. Also drops the 'pnpm -r build' step from both workflows: no package in the workspace declares a build script, so it is a no-op under pnpm 9 and an error under pnpm 10.
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
testjob inci.ymlcarried a job-levelcontinue-on-error: true, so a failing package test surfaced as a red check but left the workflow conclusion green — nothing blocked a merge. That is how theobject-treeset_and_commit/set_many_and_commitverify+revert signature bug (fixed in #115) reachedmain: the deployed functions take a defaultedmessage textargument that the verify scripts omitted, so::regprocedurecould not resolve them.test: runs-on: ubuntu-latest - continue-on-error: true strategy: fail-fast: false # unchanged: one red package still lets the others reportfail-fast: falsestays, so a single failure still doesn't cancel the sibling shards — it just stops being advisory.The matrix also predates four packages that have
__tests__/and atestscript, so their unit tests never ran anywhere (onlyintegration-test's deploy→verify→revert cycle touched them):All four pass locally against
constructiveio/postgres-plus:18, which is why they are safe to make blocking in the same PR.Finally, both workflows ran
pnpm -r buildbetweenpnpm installand the database setup. No package in this workspace declares abuildscript, so pnpm 9 printsNone of the selected packages has a "build" scriptand moves on, while pnpm 10+ treats it as an error — a latent break on the next toolchain bump, and dead time on every run today. Dropped fromci.ymlandintegration-test.yml.Verification
npx jestin each ofpackages/{inflection-db,object-store,object-tree,partman}— green (counts above)."build"script exists in the root manifest or anypackages/*/package.jsonbefore removing the step.Link to Devin session: https://app.devin.ai/sessions/43b0b10711174fa49d51907bf2b0c25f
Requested by: @pyramation