Skip to content

ci: make package test failures fail the build, cover four untested packages - #117

Merged
pyramation merged 1 commit into
mainfrom
feat/ci-report-test-failures
Aug 8, 2026
Merged

ci: make package test failures fail the build, cover four untested packages#117
pyramation merged 1 commit into
mainfrom
feat/ci-report-test-failures

Conversation

@pyramation

Copy link
Copy Markdown
Contributor

Summary

The test job in ci.yml carried a job-level continue-on-error: true, so a failing package test surfaced as a red check but left the workflow conclusion green — nothing blocked a merge. That is how the object-tree set_and_commit / set_many_and_commit verify+revert signature bug (fixed in #115) reached main: the deployed functions take a defaulted message text argument that the verify scripts omitted, so ::regprocedure could not resolve them.

   test:
     runs-on: ubuntu-latest
-    continue-on-error: true
     strategy:
       fail-fast: false     # unchanged: one red package still lets the others report

fail-fast: false stays, so a single failure still doesn't cancel the sibling shards — it just stops being advisory.

The matrix also predates four packages that have __tests__/ and a test script, so their unit tests never ran anywhere (only integration-test's deploy→verify→revert cycle touched them):

+ inflection-db   1 suite,  29 tests
+ object-store    6 suites, 28 tests
+ object-tree     7 suites, 14 tests
+ partman         1 suite,   2 tests

All four pass locally against constructiveio/postgres-plus:18, which is why they are safe to make blocking in the same PR.

Finally, both workflows ran pnpm -r build between pnpm install and the database setup. No package in this workspace declares a build script, so pnpm 9 prints None of the selected packages has a "build" script and moves on, while pnpm 10+ treats it as an error — a latent break on the next toolchain bump, and dead time on every run today. Dropped from ci.yml and integration-test.yml.

Verification

  • npx jest in each of packages/{inflection-db,object-store,object-tree,partman} — green (counts above).
  • Confirmed no "build" script exists in the root manifest or any packages/*/package.json before removing the step.

Link to Devin session: https://app.devin.ai/sessions/43b0b10711174fa49d51907bf2b0c25f
Requested by: @pyramation

…ckages

The test job carried continue-on-error: true, so a red package test reported as
a failed check but left the workflow green — the object-tree verify/revert
signature bug reached main that way. The matrix also skipped every package with
tests that was added after it was written.

Also drops the 'pnpm -r build' step from both workflows: no package in the
workspace declares a build script, so it is a no-op under pnpm 9 and an error
under pnpm 10.
@pyramation pyramation self-assigned this Aug 8, 2026
@devin-ai-integration

Copy link
Copy Markdown
Contributor

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment, CI, and merge conflict monitoring

@pyramation
pyramation merged commit 8783f3e into main Aug 8, 2026
29 checks passed
@pyramation
pyramation deleted the feat/ci-report-test-failures branch August 8, 2026 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant