feat(desktop): personal or organization principals, chosen not typed - #30
Merged
Conversation
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A principal no longer has to belong to an organization, and the org it does belong to is picked rather than typed.
orgIdbecomes optional the whole way down —CreatePrincipalOptions,CreatePrincipalRequest, the IPC validator,--org— and its absence means personal: a sub-identity owned by you, reaching wherever you do, which is the shape an unattended job of your own actually wants.The personal mutation is sent by hand, and that is a codegen bug worth knowing about. The auth schema does expose it —
— but the generated ORM has no
mutation.createPrincipal: the principals table's CRUD create carries the same inflected name and shadowed the procedure, so the typed surface offerscreateOrgPrincipalalone, andclient.principal.createsends the wrong (nested,ownerId+userId) input. So the personal path goes through the SDK's ownauth.FetchAdapterwith the flat input above, and everything else — step-up hold/replay,rethrow, the endpoint explanations — is unchanged around it.The dialog gains a Scope select (Personal / Organization); the organization row only exists for the second, and it is a dropdown of ids, with a free-text field behind "Another organization…" for the first principal in an org.
Those ids come from
knownOrgIds(principals, keys)— the orgs this account has demonstrably scoped something to already (a principal'sentityIds, an org key'sorgId). Not a membership query, because there isn't one to call: memberships live behind the admin surface, which a signed-in user's own token does not reach. Offering ids the account has used is honest; inventing a list would not be.Testing
knownOrgIds(dedupes, gathers from both sources, empty for a fresh account), a personal principal creating withentityIds: [], and the CLI's principal command now failing on a missing account rather than a missing--org. Desktop typecheck/lint/test,pnpm build/lint/testat the root: green.Link to Devin session: https://app.devin.ai/sessions/04636534e07048089ffb6b78142e12cd
Requested by: @pyramation