feat(desktop): edit a vault item — change a value, remove a field, rename it - #25
Merged
Conversation
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
An item's fields were write-once in the UI: you could add, reveal, copy and never change. So rotating a password meant deleting the item. This adds the missing three: edit a value, remove a field, rename the item.
No new IPC or vault surface — the database already supported all of it, only the UI didn't call it. Editing is
set_fieldwith the same name and purpose, which the procedure resolves asON CONFLICT (item_id, name) DO UPDATE, so the row is replaced in place and the fields trigger keeps the previous value in the item's password history:Carrying
field.purposeandfield.concealedthrough matters: dropping either would silently turn atotp_seedintotext(breaking the code display) or unconceal a password.Editing takes over the row — reveal/copy hide while it does, so there's no way to copy a half-typed value — and
Escabandons,Entersaves. Removing a field is behind a confirm that says plainly it is not the trash and cannot be undone, unlike an item. The title is click-to-rename in place,Escto abandon.Link to Devin session: https://app.devin.ai/sessions/04636534e07048089ffb6b78142e12cd
Requested by: @pyramation