Make so EffSc can be consumed without Spongefish#104
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Splits the
spongefishCargo feature out ofarkworksso downstream crates can consume effsc with arkworks fields but no Fiat-Shamir backend. Adds the missingVerifierTranscriptblanket onspongefish::VerifierState(symmetric to the existingProverTranscriptblanket) so consumers no longer need a hand-written verifier adapter. Drops the now-redundantSpongefishTranscriptwrapper struct.Breaking change
effsc::transcript::SpongefishTranscriptis removed — replaceSpongefishTranscript::new(state)with the rawstate(the blanket impl makes&mut ProverState<H, R>directly usable wherever&mut impl ProverTranscript<F>is expected).Changes
Cargo.toml—spongefishis now its own feature (impliesarkworks);arkworksno longer pulls spongefish. Promotesrand_corefrom a transitive to a direct dep sosanity.rscan nameRngCorewithout going throughark-std.src/transcript/mod.rs— ungatessanity; gatesspongefishmodule on the new feature; drops theSpongefishTranscriptre-export.src/transcript/sanity.rs—F: ark_ff::Field→F: SumcheckField,R: Rng→R: RngCore,F::rand(rng)→F::from_u64(rng.next_u64()). Now compiles under--no-default-features.src/transcript/spongefish.rs— deletes the wrapper struct and its inherent methods; adds theVerifierTranscriptblanket onVerifierState<'a, H>.src/coefficient_sumcheck.rs— test passes raw&mut prover_stateinstead of wrapping it.Test plan
cargo build --no-default-features --features=arkworkssucceeds;cargo treeconfirms no spongefish in the dep graphcargo build --no-default-featuressucceedscargo build(default features) succeedscargo test --all-features— 128 tests passcargo clippy --all-features --libclean (pre-existing lints in test files unchanged)