[wip] [feature] timeit xmagic enabled for native and lite case by kr-2003 · Pull Request #289 · compiler-research/xeus-cpp

kr-2003 · 2025-04-16T18:38:43Z

Native

timeit-native.mp4

Lite

timeit-lite.mp4

codecov-commenter · 2025-04-16T18:41:31Z

Codecov Report

Attention: Patch coverage is 90.73171% with 19 lines in your changes missing coverage. Please review.

Project coverage is 83.18%. Comparing base (9458ebe) to head (989a66e).
Report is 2 commits behind head on main.

Files with missing lines	Patch %	Lines
src/xmagics/execution.cpp	88.55%	19 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #289      +/-   ##
==========================================
+ Coverage   80.87%   83.18%   +2.30%     
==========================================
  Files          20       22       +2     
  Lines         957     1130     +173     
  Branches       88       98      +10     
==========================================
+ Hits          774      940     +166     
- Misses        183      190       +7

Files with missing lines	Coverage Δ
src/xinterpreter.cpp	`91.39% <100.00%> (+0.18%)`	⬆️
src/xmagics/execution.hpp	`100.00% <100.00%> (ø)`
src/xmagics/execution.cpp	`88.55% <88.55%> (ø)`

... and 2 files with indirect coverage changes

Files with missing lines	Coverage Δ
src/xinterpreter.cpp	`91.39% <100.00%> (+0.18%)`	⬆️
src/xmagics/execution.hpp	`100.00% <100.00%> (ø)`
src/xmagics/execution.cpp	`88.55% <88.55%> (ø)`

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

anutosh491 · 2025-04-16T18:45:09Z

Thanks a lot for this @kr-2003

Hopefully you were able to get past the output re-direction thingy we were discussing.

github-actions

clang-tidy made some suggestions

There were too many comments to post at once. Showing the first 10 out of 68. Check the log or trigger a new build to see more.

github-actions · 2025-04-16T18:47:41Z


-void* createInterpreter(const Args &ExtraArgs = {}) {
-  Args ClangArgs = {/*"-xc++"*/"-v"}; // ? {"-Xclang", "-emit-llvm-only", "-Xclang", "-diagnostic-log-file", "-Xclang", "-", "-xc++"};
+void* createInterpreter(const Args& ExtraArgs = {})


warning: function 'createInterpreter' can be made static or moved into an anonymous namespace to enforce internal linkage [misc-use-internal-linkage]

Suggested change

void* createInterpreter(const Args& ExtraArgs = {})

static void* createInterpreter(const Args& ExtraArgs = {})

github-actions · 2025-04-16T18:47:41Z

-    ClangArgs.push_back("-isystem");
-    ClangArgs.push_back(CxxInclude.c_str());
-  }
+    if (std::find_if(


warning: no header providing "std::find_if" is directly included [misc-include-cleaner]

src/xinterpreter.cpp:21:

- #ifndef EMSCRIPTEN + #include <algorithm> + #ifndef EMSCRIPTEN

github-actions · 2025-04-16T18:47:41Z

+    if (std::find_if(
+            ExtraArgs.begin(),
+            ExtraArgs.end(),
+            [](const std::string& s)


warning: no header providing "std::string" is directly included [misc-include-cleaner]

src/xinterpreter.cpp:21:

- #ifndef EMSCRIPTEN + #include <string> + #ifndef EMSCRIPTEN

github-actions · 2025-04-16T18:47:42Z

+        )
+        == ExtraArgs.end())
+    {
+        std::string resource_dir = Cpp::DetectResourceDir();


warning: no header providing "Cpp::DetectResourceDir" is directly included [misc-include-cleaner]

src/xinterpreter.cpp:21:

- #ifndef EMSCRIPTEN + #include <clang/Interpreter/CppInterOp.h> + #ifndef EMSCRIPTEN

github-actions · 2025-04-16T18:47:42Z

+        std::string resource_dir = Cpp::DetectResourceDir();
+        if (resource_dir.empty())
+        {
+            std::cerr << "Failed to detect the resource-dir\n";


warning: no header providing "std::cerr" is directly included [misc-include-cleaner]

src/xinterpreter.cpp:21:

- #ifndef EMSCRIPTEN + #include <iostream> + #ifndef EMSCRIPTEN

github-actions · 2025-04-16T18:47:42Z

+        ClangArgs.push_back(resource_dir.c_str());
+    }
+    std::vector<std::string> CxxSystemIncludes;
+    Cpp::DetectSystemCompilerIncludePaths(CxxSystemIncludes);


warning: no header providing "Cpp::DetectSystemCompilerIncludePaths" is directly included [misc-include-cleaner]

Cpp::DetectSystemCompilerIncludePaths(CxxSystemIncludes); ^

github-actions · 2025-04-16T18:47:42Z

+    ClangArgs.insert(ClangArgs.end(), ExtraArgs.begin(), ExtraArgs.end());
+    // FIXME: We should process the kernel input options and conditionally pass
+    // the gpu args here.
+    return Cpp::CreateInterpreter(ClangArgs /*, {"-cuda"}*/);


warning: no header providing "Cpp::CreateInterpreter" is directly included [misc-include-cleaner]

return Cpp::CreateInterpreter(ClangArgs /*, {"-cuda"}*/); ^

github-actions · 2025-04-16T18:47:42Z

-        err = Cpp::EndStdStreamCapture();
-        std::cout << out;
-      }
+    struct StreamRedirectRAII


warning: class 'StreamRedirectRAII' defines a non-default destructor but does not define a copy constructor, a copy assignment operator, a move constructor or a move assignment operator [cppcoreguidelines-special-member-functions]

struct StreamRedirectRAII ^

github-actions · 2025-04-16T18:47:42Z

-      }
+    struct StreamRedirectRAII
+    {
+        std::string& err;


warning: member 'err' of type 'std::string &' (aka 'basic_string &') is a reference [cppcoreguidelines-avoid-const-or-ref-data-members]

std::string& err; ^

github-actions · 2025-04-16T18:47:42Z

+        StreamRedirectRAII(std::string& e)
+            : err(e)
+        {
+            Cpp::BeginStdStreamCapture(Cpp::kStdErr);


warning: no header providing "Cpp::BeginStdStreamCapture" is directly included [misc-include-cleaner]

Cpp::BeginStdStreamCapture(Cpp::kStdErr); ^

kr-2003 · 2025-04-16T18:47:51Z

Thanks a lot for this @kr-2003

Hopefully you were able to get past the output re-direction thingy we were discussing.

Yes, there are some things left to do here. Although the feature is working fine for now.
I'll see the following remaining tasks tomorrow:

CI Tests failing
Test coverage for timeit
Other code suggestions by github-actions bot

github-actions

clang-tidy made some suggestions

There were too many comments to post at once. Showing the first 10 out of 60. Check the log or trigger a new build to see more.

github-actions · 2025-04-17T09:12:33Z

+        StreamRedirectRAII(std::string& e)
+            : err(e)
+        {
+            Cpp::BeginStdStreamCapture(Cpp::kStdErr);


warning: no header providing "Cpp::kStdErr" is directly included [misc-include-cleaner]

Cpp::BeginStdStreamCapture(Cpp::kStdErr); ^

github-actions · 2025-04-17T09:12:33Z

+            : err(e)
+        {
+            Cpp::BeginStdStreamCapture(Cpp::kStdErr);
+            Cpp::BeginStdStreamCapture(Cpp::kStdOut);


warning: no header providing "Cpp::kStdOut" is directly included [misc-include-cleaner]

Cpp::BeginStdStreamCapture(Cpp::kStdOut); ^

github-actions · 2025-04-17T09:12:34Z

+
+        ~StreamRedirectRAII()
+        {
+            std::string out = Cpp::EndStdStreamCapture();


warning: no header providing "Cpp::EndStdStreamCapture" is directly included [misc-include-cleaner]

std::string out = Cpp::EndStdStreamCapture(); ^

github-actions · 2025-04-17T09:12:34Z

+        {
+            std::string out = Cpp::EndStdStreamCapture();
+            err = Cpp::EndStdStreamCapture();
+            std::cout << out;


warning: no header providing "std::cout" is directly included [misc-include-cleaner]

std::cout << out; ^

github-actions · 2025-04-17T09:12:34Z

-    interpreter::interpreter(int argc, const char* const* argv) :
-        xmagics()
+    interpreter::interpreter(int argc, const char* const* argv)
+        : xmagics()


warning: initializer for member 'xmagics' is redundant [readability-redundant-member-init]

Suggested change

: xmagics()

:

github-actions · 2025-04-17T09:12:34Z

            auto found1 = found++;
-            while (isspace(code[++found1])) ;
-            return xeus::create_is_complete_reply("incomplete", code.substr(found, found1-found));
+            while (isspace(code[++found1]))


warning: no header providing "isspace" is directly included [misc-include-cleaner]

src/xinterpreter.cpp:21:

- #ifndef EMSCRIPTEN + #include <cctype> + #ifndef EMSCRIPTEN

github-actions · 2025-04-17T09:12:34Z

+
+#include "execution.hpp"
+#include "xeus-cpp/xinterpreter.hpp"
+


warning: included header xinterpreter.hpp is not used directly [misc-include-cleaner]

Suggested change

github-actions · 2025-04-17T09:12:34Z

+
+namespace xcpp
+{
+    struct StreamRedirectRAII


warning: class 'StreamRedirectRAII' defines a non-default destructor but does not define a copy constructor, a copy assignment operator, a move constructor or a move assignment operator [cppcoreguidelines-special-member-functions]

struct StreamRedirectRAII ^

github-actions · 2025-04-17T09:12:34Z

+{
+    struct StreamRedirectRAII
+    {
+        std::string& err;


warning: member 'err' of type 'std::string &' (aka 'basic_string &') is a reference [cppcoreguidelines-avoid-const-or-ref-data-members]

std::string& err; ^

github-actions · 2025-04-17T09:12:35Z

+{
+    struct StreamRedirectRAII
+    {
+        std::string& err;


warning: no header providing "std::string" is directly included [misc-include-cleaner]

src/xmagics/execution.cpp:13:

+ #include <string>

github-actions

clang-tidy made some suggestions

There were too many comments to post at once. Showing the first 10 out of 48. Check the log or trigger a new build to see more.

github-actions · 2025-04-17T19:04:51Z

+        {
+            std::string out = Cpp::EndStdStreamCapture();
+            err = Cpp::EndStdStreamCapture();
+            std::cout << out;


warning: no header providing "std::cout" is directly included [misc-include-cleaner]

src/xmagics/execution.cpp:13:

+ #include <iostream>

github-actions · 2025-04-17T19:04:51Z

+    {
+    }
+
+    void timeit::get_options(argparser& argpars)


warning: method 'get_options' can be made static [readability-convert-member-functions-to-static]

src/xmagics/execution.hpp:47:

- void get_options(argparser& argpars); + static void get_options(argparser& argpars);

github-actions · 2025-04-17T19:04:51Z

+    {
+    }
+
+    void timeit::get_options(argparser& argpars)


warning: no header providing "xcpp::argparser" is directly included [misc-include-cleaner]

src/xmagics/execution.cpp:12:

- #include "clang/Interpreter/CppInterOp.h" + #include "xeus-cpp/xoptions.hpp" + #include "clang/Interpreter/CppInterOp.h"

github-actions · 2025-04-17T19:04:51Z

+            .nargs(0);
+    }
+
+    std::string timeit::inner(std::size_t number, const std::string& code, int exec_counter) const


warning: method 'inner' can be made static [readability-convert-member-functions-to-static]

src/xmagics/execution.hpp:48:

- std::string inner(std::size_t number, const std::string& code, int exec_counter) const; + static std::string inner(std::size_t number, const std::string& code, int exec_counter) ;

Suggested change

std::string timeit::inner(std::size_t number, const std::string& code, int exec_counter) const

std::string timeit::inner(std::size_t number, const std::string& code, int exec_counter)

github-actions · 2025-04-17T19:04:51Z

+            .nargs(0);
+    }
+
+    std::string timeit::inner(std::size_t number, const std::string& code, int exec_counter) const


warning: no header providing "std::size_t" is directly included [misc-include-cleaner]

src/xmagics/execution.cpp:13:

+ #include <cstddef>

github-actions · 2025-04-17T19:04:52Z

+    std::string timeit::inner(std::size_t number, const std::string& code, int exec_counter) const
+    {
+        static std::size_t counter = 0;  // Ensure unique lambda names
+        std::string unique_id = std::to_string(counter++);


warning: no header providing "std::to_string" is directly included [misc-include-cleaner]

std::string unique_id = std::to_string(counter++); ^

github-actions · 2025-04-17T19:04:52Z

+    {
+        static std::size_t counter = 0;  // Ensure unique lambda names
+        std::string unique_id = std::to_string(counter++);
+        std::string timeit_code = "";


warning: redundant string initialization [readability-redundant-string-init]

Suggested change

std::string timeit_code = "";

std::string timeit_code;

github-actions · 2025-04-17T19:04:52Z

+        timeit_code += "auto user_code_" + unique_id + " = []() {\n";
+        timeit_code += "   " + code + "\n";
+        timeit_code += "};\n";
+        timeit_code += "get_elapsed_time_" + std::to_string(exec_counter) + "(" + std::to_string(number)


warning: no header providing "std::to_string" is directly included [misc-include-cleaner]

timeit_code += "get_elapsed_time_" + std::to_string(exec_counter) + "(" + std::to_string(number) ^

github-actions · 2025-04-17T19:04:52Z

+        return timeit_code;
+    }
+
+    std::string timeit::_format_time(double timespan, std::size_t precision) const


warning: method '_format_time' can be made static [readability-convert-member-functions-to-static]

src/xmagics/execution.hpp:49:

- std::string _format_time(double timespan, std::size_t precision) const; + static std::string _format_time(double timespan, std::size_t precision) ;

Suggested change

std::string timeit::_format_time(double timespan, std::size_t precision) const

std::string timeit::_format_time(double timespan, std::size_t precision)

github-actions

clang-tidy made some suggestions

There were too many comments to post at once. Showing the first 10 out of 39. Check the log or trigger a new build to see more.

github-actions · 2025-04-18T05:22:41Z

+
+    std::string timeit::_format_time(double timespan, std::size_t precision) const
+    {
+        std::vector<std::string> units{"s", "ms", "us", "ns"};


warning: no header providing "std::vector" is directly included [misc-include-cleaner]

src/xmagics/execution.cpp:13:

+ #include <vector>

github-actions · 2025-04-18T05:22:41Z

+    {
+        std::vector<std::string> units{"s", "ms", "us", "ns"};
+        std::vector<double> scaling{1, 1e3, 1e6, 1e9};
+        std::ostringstream output;


warning: no header providing "std::ostringstream" is directly included [misc-include-cleaner]

src/xmagics/execution.cpp:13:

+ #include <sstream>

github-actions · 2025-04-18T05:22:41Z

+        std::vector<std::string> units{"s", "ms", "us", "ns"};
+        std::vector<double> scaling{1, 1e3, 1e6, 1e9};
+        std::ostringstream output;
+        int order;


warning: variable 'order' is not initialized [cppcoreguidelines-init-variables]

Suggested change

int order;

int order = 0;

github-actions · 2025-04-18T05:22:42Z

+
+        if (timespan > 0.0)
+        {
+            order = std::min(-static_cast<int>(std::floor(std::floor(std::log10(timespan)) / 3)), 3);


warning: no header providing "std::floor" is directly included [misc-include-cleaner]

src/xmagics/execution.cpp:13:

+ #include <cmath>

github-actions · 2025-04-18T05:22:42Z

+
+        if (timespan > 0.0)
+        {
+            order = std::min(-static_cast<int>(std::floor(std::floor(std::log10(timespan)) / 3)), 3);


warning: no header providing "std::log10" is directly included [misc-include-cleaner]

order = std::min(-static_cast<int>(std::floor(std::floor(std::log10(timespan)) / 3)), 3); ^

github-actions · 2025-04-18T05:22:42Z

+
+        if (timespan > 0.0)
+        {
+            order = std::min(-static_cast<int>(std::floor(std::floor(std::log10(timespan)) / 3)), 3);


warning: no header providing "std::min" is directly included [misc-include-cleaner]

src/xmagics/execution.cpp:13:

+ #include <algorithm>

github-actions · 2025-04-18T05:22:42Z

+        {
+            order = 3;
+        }
+        output.precision(precision);


warning: narrowing conversion from 'std::size_t' (aka 'unsigned long') to signed type 'streamsize' (aka 'long') is implementation-defined [cppcoreguidelines-narrowing-conversions]

output.precision(precision); ^

github-actions · 2025-04-18T05:22:42Z

+    void timeit::execute(std::string& line, std::string& cell)
+    {
+        exec_counter++;
+        argparser argpars("timeit", XEUS_CPP_VERSION, argparse::default_arguments::none);


warning: no header providing "XEUS_CPP_VERSION" is directly included [misc-include-cleaner]

src/xmagics/execution.cpp:9:

- #include "xeus-cpp/xinterpreter.hpp" + #include "xeus-cpp/xeus_cpp_config.hpp" + #include "xeus-cpp/xinterpreter.hpp"

github-actions · 2025-04-18T05:22:42Z

+    void timeit::execute(std::string& line, std::string& cell)
+    {
+        exec_counter++;
+        argparser argpars("timeit", XEUS_CPP_VERSION, argparse::default_arguments::none);


warning: no header providing "argparse::default_arguments" is directly included [misc-include-cleaner]

src/xmagics/execution.cpp:13:

+ #include <argparse/argparse.hpp>

github-actions · 2025-04-18T05:22:42Z

+                code += " " + s;
+            }
+        }
+        catch (std::logic_error& e)


warning: no header providing "std::logic_error" is directly included [misc-include-cleaner]

src/xmagics/execution.cpp:13:

+ #include <stdexcept>

github-actions

clang-tidy made some suggestions

There were too many comments to post at once. Showing the first 10 out of 30. Check the log or trigger a new build to see more.

github-actions · 2025-04-19T07:41:44Z

+    void timeit::operator()(const std::string& line)
+    {
+        std::string cline = line;
+        std::string ccell = "";


warning: redundant string initialization [readability-redundant-string-init]

Suggested change

std::string ccell = "";

std::string ccell;

github-actions · 2025-04-19T07:41:44Z

+        execute(cline, ccell);
+    }
+
+    void timeit::get_options(argparser& argpars)


warning: method 'get_options' can be made static [readability-convert-member-functions-to-static]

src/xmagics/execution.hpp:35:

- void get_options(argparser& argpars); + static void get_options(argparser& argpars);

github-actions · 2025-04-19T07:41:44Z

+            .nargs(0);
+    }
+
+    std::string timeit::inner(std::size_t number, const std::string& code, int exec_counter) const


warning: method 'inner' can be made static [readability-convert-member-functions-to-static]

src/xmagics/execution.hpp:36:

- std::string inner(std::size_t number, const std::string& code, int exec_counter) const; + static std::string inner(std::size_t number, const std::string& code, int exec_counter) ;

Suggested change

std::string timeit::inner(std::size_t number, const std::string& code, int exec_counter) const

std::string timeit::inner(std::size_t number, const std::string& code, int exec_counter)

github-actions · 2025-04-19T07:41:45Z

+        return timeit_code;
+    }
+
+    std::string timeit::_format_time(double timespan, std::size_t precision) const


warning: method '_format_time' can be made static [readability-convert-member-functions-to-static]

src/xmagics/execution.hpp:37:

- std::string _format_time(double timespan, std::size_t precision) const; + static std::string _format_time(double timespan, std::size_t precision) ;

Suggested change

std::string timeit::_format_time(double timespan, std::size_t precision) const

std::string timeit::_format_time(double timespan, std::size_t precision)

github-actions · 2025-04-19T07:41:45Z

+        {
+            if (trim(cell).empty() && (argpars["-h"] == false))
+            {
+                std::cerr << "No expression given to evaluate" << std::endl;


warning: do not use 'std::endl' with streams; use '\n' instead [performance-avoid-endl]

Suggested change

std::cerr << "No expression given to evaluate" << std::endl;

std::cerr << "No expression given to evaluate" << '\n';

github-actions · 2025-04-19T07:41:45Z

+        {
+            if (trim(cell).empty() && (argpars["-h"] == false))
+            {
+                std::cerr << "No expression given to evaluate" << std::endl;


warning: no header providing "std::cerr" is directly included [misc-include-cleaner]

std::cerr << "No expression given to evaluate" << std::endl; ^

github-actions · 2025-04-19T07:41:45Z

+        {
+            if (trim(cell).empty() && (argpars["-h"] == false))
+            {
+                std::cerr << "No expression given to evaluate" << std::endl;


warning: no header providing "std::endl" is directly included [misc-include-cleaner]

src/xmagics/execution.cpp:13:

+ #include <ostream>

github-actions · 2025-04-19T07:41:45Z

+        bool hadError = false;
+
+        bool compilation_result = true;
+        compilation_result = Cpp::Process("#include <chrono>\n#include <iostream>\n");


warning: Value stored to 'compilation_result' is never read [clang-analyzer-deadcode.DeadStores]

compilation_result = Cpp::Process("#include <chrono>\n#include <iostream>\n"); ^

Additional context

src/xmagics/execution.cpp:156: Value stored to 'compilation_result' is never read

compilation_result = Cpp::Process("#include <chrono>\n#include <iostream>\n"); ^

github-actions · 2025-04-19T07:41:45Z

+                }
+            )";
+
+        compilation_result = Cpp::Process(timing_function.c_str());


warning: Value stored to 'compilation_result' is never read [clang-analyzer-deadcode.DeadStores]

compilation_result = Cpp::Process(timing_function.c_str()); ^

Additional context

src/xmagics/execution.cpp:172: Value stored to 'compilation_result' is never read

compilation_result = Cpp::Process(timing_function.c_str()); ^

github-actions · 2025-04-19T07:41:45Z

+        try
+        {
+            StreamRedirectRAII R(err);
+            std::ostringstream buffer_out, buffer_err;


warning: multiple declarations in a single statement reduces readability [readability-isolate-declaration]

Suggested change

std::ostringstream buffer_out, buffer_err;

std::ostringstream buffer_out;

std::ostringstream buffer_err;

github-actions

clang-tidy made some suggestions

There were too many comments to post at once. Showing the first 10 out of 21. Check the log or trigger a new build to see more.

github-actions · 2025-04-19T08:01:40Z

+        bool hadError = false;
+
+        bool compilation_result = true;
+        compilation_result = Cpp::Process("#include <chrono>\n");


warning: Value stored to 'compilation_result' is never read [clang-analyzer-deadcode.DeadStores]

compilation_result = Cpp::Process("#include <chrono>\n"); ^

Additional context

src/xmagics/execution.cpp:156: Value stored to 'compilation_result' is never read

compilation_result = Cpp::Process("#include <chrono>\n"); ^

github-actions · 2025-04-19T08:01:40Z

+        {
+            StreamRedirectRAII R(err);
+            std::ostringstream buffer_out, buffer_err;
+            std::streambuf* old_cout = std::cout.rdbuf(buffer_out.rdbuf());


warning: no header providing "std::streambuf" is directly included [misc-include-cleaner]

src/xmagics/execution.cpp:13:

+ #include <streambuf>

github-actions · 2025-04-19T08:01:40Z

+            std::cout.rdbuf(old_cout);
+            std::cerr.rdbuf(old_cerr);
+        }
+        catch (std::exception& e)


warning: no header providing "std::exception" is directly included [misc-include-cleaner]

src/xmagics/execution.cpp:13:

+ #include <exception>

github-actions · 2025-04-19T08:01:40Z

+        {
+            for (std::size_t n = 0; n < 10; ++n)
+            {
+                number = std::pow(10, n);


warning: narrowing conversion from 'typename __gnu_cxx::__promote_2<int, unsigned long>::__type' (aka 'double') to 'int' [cppcoreguidelines-narrowing-conversions]

number = std::pow(10, n); ^

github-actions · 2025-04-19T08:01:40Z

+        {
+            for (std::size_t n = 0; n < 10; ++n)
+            {
+                number = std::pow(10, n);


warning: no header providing "std::pow" is directly included [misc-include-cleaner]

number = std::pow(10, n); ^

github-actions · 2025-04-19T08:01:40Z

+            {
+                number = std::pow(10, n);
+                std::string timeit_code = inner(number, code, exec_counter);
+                std::ostringstream buffer_out, buffer_err;


warning: multiple declarations in a single statement reduces readability [readability-isolate-declaration]

Suggested change

std::ostringstream buffer_out, buffer_err;

std::ostringstream buffer_out;

std::ostringstream buffer_err;

github-actions · 2025-04-19T08:01:40Z

+                auto res_ptr = Cpp::Evaluate(timeit_code.c_str(), &hadError);
+                std::cout.rdbuf(old_cout);
+                std::cerr.rdbuf(old_cerr);
+                output = std::to_string(res_ptr);


warning: no header providing "std::to_string" is directly included [misc-include-cleaner]

output = std::to_string(res_ptr); ^

github-actions · 2025-04-19T08:01:40Z

+                std::cerr.rdbuf(old_cerr);
+                output = std::to_string(res_ptr);
+                err += buffer_err.str();
+                double elapsed_time = std::stod(output) * 1e-6;


warning: no header providing "std::stod" is directly included [misc-include-cleaner]

double elapsed_time = std::stod(output) * 1e-6; ^

github-actions · 2025-04-19T08:01:40Z

+        for (std::size_t r = 0; r < static_cast<std::size_t>(repeat); ++r)
+        {
+            std::string timeit_code = inner(number, code, exec_counter);
+            std::ostringstream buffer_out, buffer_err;


warning: multiple declarations in a single statement reduces readability [readability-isolate-declaration]

Suggested change

std::ostringstream buffer_out, buffer_err;

std::ostringstream buffer_out;

std::ostringstream buffer_err;

github-actions · 2025-04-19T08:01:41Z

+        {
+            stdev += (all_runs[r] - mean) * (all_runs[r] - mean);
+        }
+        stdev = std::sqrt(stdev / repeat);


warning: no header providing "std::sqrt" is directly included [misc-include-cleaner]

stdev = std::sqrt(stdev / repeat); ^

github-actions

clang-tidy made some suggestions

There were too many comments to post at once. Showing the first 10 out of 11. Check the log or trigger a new build to see more.

github-actions · 2025-04-19T08:08:23Z

+
+        std::cout << _format_time(mean, precision) << " +- " << _format_time(stdev, precision);
+        std::cout << " per loop (mean +- std. dev. of " << repeat << " run" << ((repeat == 1) ? ", " : "s ");
+        std::cout << number << " loop" << ((number == 1) ? "" : "s") << " each)" << std::endl;


warning: do not use 'std::endl' with streams; use '\n' instead [performance-avoid-endl]

Suggested change

std::cout << number << " loop" << ((number == 1) ? "" : "s") << " each)" << std::endl;

std::cout << number << " loop" << ((number == 1) ? "" : "s") << " each)" << '\n';

github-actions · 2025-04-19T08:08:23Z

+        std::cout << " per loop (mean +- std. dev. of " << repeat << " run" << ((repeat == 1) ? ", " : "s ");
+        std::cout << number << " loop" << ((number == 1) ? "" : "s") << " each)" << std::endl;
+    }
+}


warning: namespace 'xcpp' not terminated with a closing comment [llvm-namespace-comment]

src/xmagics/execution.cpp:-1:

+ // namespace xcpp

Additional context

src/xmagics/execution.cpp:14: namespace 'xcpp' starts here

namespace xcpp ^

github-actions · 2025-04-19T08:08:23Z

+ ************************************************************************************/
+
+#ifndef XMAGICS_EXECUTION_HPP
+#define XMAGICS_EXECUTION_HPP


warning: header guard does not follow preferred style [llvm-header-guard]

Suggested change

#define XMAGICS_EXECUTION_HPP

#ifndef GITHUB_WORKSPACE_SRC_XMAGICS_EXECUTION_HPP

#define GITHUB_WORKSPACE_SRC_XMAGICS_EXECUTION_HPP

github-actions · 2025-04-19T08:08:23Z

+    {
+    public:
+
+        XEUS_CPP_API


warning: no header providing "XEUS_CPP_API" is directly included [misc-include-cleaner]

src/xmagics/execution.hpp:14:

- #include "xeus-cpp/xmagics.hpp" + #include "xeus-cpp/xeus_cpp_config.hpp" + #include "xeus-cpp/xmagics.hpp"

github-actions · 2025-04-19T08:08:23Z

+    public:
+
+        XEUS_CPP_API
+        virtual void operator()(const std::string& line) override;


warning: 'virtual' is redundant since the function is already declared 'override' [cppcoreguidelines-explicit-virtual-functions]

Suggested change

virtual void operator()(const std::string& line) override;

void operator()(const std::string& line) override;

github-actions · 2025-04-19T08:08:23Z

+        virtual void operator()(const std::string& line) override;
+
+        XEUS_CPP_API
+        virtual void operator()(const std::string& line, const std::string& cell) override;


warning: 'virtual' is redundant since the function is already declared 'override' [cppcoreguidelines-explicit-virtual-functions]

Suggested change

virtual void operator()(const std::string& line, const std::string& cell) override;

void operator()(const std::string& line, const std::string& cell) override;

github-actions · 2025-04-19T08:08:23Z

+        XEUS_CPP_API
+        virtual void operator()(const std::string& line, const std::string& cell) override;
+
+    public:


warning: redundant access specifier has the same accessibility as the previous access specifier [readability-redundant-access-specifiers]

Suggested change

public:

Additional context

src/xmagics/execution.hpp:21: previously declared here

public: ^

github-actions · 2025-04-19T08:08:23Z

+    private:
+
+        void get_options(argparser& argpars);
+        std::string inner(std::size_t number, const std::string& code, int exec_counter) const;


warning: function 'inner' should be marked [[nodiscard]] [modernize-use-nodiscard]

Suggested change

std::string inner(std::size_t number, const std::string& code, int exec_counter) const;

[[nodiscard]] std::string inner(std::size_t number, const std::string& code, int exec_counter) const;

github-actions · 2025-04-19T08:08:24Z

+
+        void get_options(argparser& argpars);
+        std::string inner(std::size_t number, const std::string& code, int exec_counter) const;
+        std::string _format_time(double timespan, std::size_t precision) const;


warning: function '_format_time' should be marked [[nodiscard]] [modernize-use-nodiscard]

Suggested change

std::string _format_time(double timespan, std::size_t precision) const;

[[nodiscard]] std::string _format_time(double timespan, std::size_t precision) const;

github-actions · 2025-04-19T08:08:24Z

+
+        void get_options(argparser& argpars);
+        std::string inner(std::size_t number, const std::string& code, int exec_counter) const;
+        std::string _format_time(double timespan, std::size_t precision) const;


warning: invalid case style for function '_format_time' [readability-identifier-naming]

Suggested change

std::string _format_time(double timespan, std::size_t precision) const;

std::string format_time(double timespan, std::size_t precision) const;

anutosh491 · 2025-05-06T13:25:49Z

The effort here is good but the it won't be too ideal to keep the workaround introduced here in the source code for long.

I think this llvm/llvm-project#84769 would go in sometime soon (we have llvm 20.1.5 release planned on May 13th and llvm 20.1.6 planned on May 27th . Having it through one of these would be great)

In the meanwhile would you like to have a look at these (and try having draft PRs for these ?)

vgvassilev

This PR seem to have (almost) no tests...

kr-2003 added 2 commits April 16, 2025 23:58

added timeit xmagic for native and lite

ee97b3f

added timeit xmagic for native and lite

a5c5393

clang format

d2703cd

kr-2003 marked this pull request as draft April 16, 2025 18:42

kr-2003 changed the title ~~[feature] timeit xmagic enabled for native and lite case~~ [wip] [feature] timeit xmagic enabled for native and lite case Apr 16, 2025

github-actions bot reviewed Apr 16, 2025

View reviewed changes

added tests for timeit

c3a0565

github-actions bot reviewed Apr 17, 2025

View reviewed changes

error handling

4771adb

github-actions bot reviewed Apr 17, 2025

View reviewed changes

removed timeit def constr

6d08824

github-actions bot reviewed Apr 18, 2025

View reviewed changes

definition shifted to cpp file

08621ec

github-actions bot reviewed Apr 19, 2025

View reviewed changes

removed iostream from timeit code

989a66e

github-actions bot reviewed Apr 19, 2025

View reviewed changes

kr-2003 added 2 commits April 19, 2025 13:32

removed chrono lib

aebc3e7

added chrono lib

265fba8

github-actions bot reviewed Apr 19, 2025

View reviewed changes

vgvassilev reviewed May 20, 2025

View reviewed changes

	void* createInterpreter(const Args& ExtraArgs = {})
	static void* createInterpreter(const Args& ExtraArgs = {})


		#include "execution.hpp"
		#include "xeus-cpp/xinterpreter.hpp"

	std::string timeit::inner(std::size_t number, const std::string& code, int exec_counter) const
	std::string timeit::inner(std::size_t number, const std::string& code, int exec_counter)

	std::string timeit::_format_time(double timespan, std::size_t precision) const
	std::string timeit::_format_time(double timespan, std::size_t precision)

	std::cerr << "No expression given to evaluate" << std::endl;
	std::cerr << "No expression given to evaluate" << '\n';

	std::ostringstream buffer_out, buffer_err;
	std::ostringstream buffer_out;
	std::ostringstream buffer_err;

	std::cout << number << " loop" << ((number == 1) ? "" : "s") << " each)" << std::endl;
	std::cout << number << " loop" << ((number == 1) ? "" : "s") << " each)" << '\n';

	#define XMAGICS_EXECUTION_HPP
	#ifndef GITHUB_WORKSPACE_SRC_XMAGICS_EXECUTION_HPP
	#define GITHUB_WORKSPACE_SRC_XMAGICS_EXECUTION_HPP

	virtual void operator()(const std::string& line) override;
	void operator()(const std::string& line) override;

	virtual void operator()(const std::string& line, const std::string& cell) override;
	void operator()(const std::string& line, const std::string& cell) override;

	std::string inner(std::size_t number, const std::string& code, int exec_counter) const;
	[[nodiscard]] std::string inner(std::size_t number, const std::string& code, int exec_counter) const;

	std::string _format_time(double timespan, std::size_t precision) const;
	[[nodiscard]] std::string _format_time(double timespan, std::size_t precision) const;

	std::string _format_time(double timespan, std::size_t precision) const;
	std::string format_time(double timespan, std::size_t precision) const;

Conversation

kr-2003 commented Apr 16, 2025

Native

Lite

Uh oh!

codecov-commenter commented Apr 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

anutosh491 commented Apr 16, 2025

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot Apr 16, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Apr 16, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Apr 16, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Apr 16, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Apr 16, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Apr 16, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Apr 16, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Apr 16, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Apr 16, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Apr 16, 2025

Choose a reason for hiding this comment

Uh oh!

kr-2003 commented Apr 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot Apr 17, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Apr 17, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Apr 17, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Apr 17, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Apr 17, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Apr 17, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Apr 17, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Apr 17, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Apr 17, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Apr 17, 2025

Choose a reason for hiding this comment

Uh oh!

codecov-commenter commented Apr 16, 2025 •

edited

Loading

kr-2003 commented Apr 16, 2025 •

edited

Loading