Update deprecated GitHub Actions (checkout, setup-node v2 -> v4)#82
Conversation
There was a problem hiding this comment.
Pull request overview
Adds GitHub Actions workflow linting via actionlint as part of an org-wide rollout, and updates existing workflows to use current major versions of core GitHub Actions.
Changes:
- Add a new workflow to run
actionlintwhen workflow/config files change. - Add an
.github/actionlint.yamlconfiguration (runner labels + shellcheck gating). - Bump
actions/checkoutandactions/setup-nodetov4in the Node CI workflow.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
.github/workflows/node.js.yml |
Updates checkout/setup-node to v4 (but introduces/retains invalid steps: indentation that must be fixed). |
.github/workflows/lint-actions.yml |
Adds a workflow running actionlint on workflow/config changes. |
.github/actionlint.yaml |
Adds actionlint configuration (self-hosted runner labels + shellcheck ignore rules). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| steps: | ||
| - uses: actions/checkout@v2 | ||
| - uses: actions/checkout@v4 | ||
| - name: Use Node.js ${{ matrix.node-version }} | ||
| uses: actions/setup-node@v2 | ||
| uses: actions/setup-node@v4 | ||
| with: |
There was a problem hiding this comment.
Declining — this is valid YAML. Block sequence entries may sit at the same indentation column as their parent mapping key (a "zero-indented" block sequence); it parses identically to the extra-indented form. This workflow has parsed and run in exactly this form for years, and actionlint — which uses a real YAML parser — passes it cleanly.
| push: | ||
| branches: [main] | ||
| paths: ['.github/workflows/**', '.github/actionlint.yaml'] |
- actions/checkout v2 -> v4 - actions/setup-node v2 -> v4 Found by an org-wide actionlint sweep; the lint tooling itself is staying in the core repos only, but these fixes stand on their own. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
24d7417 to
176c069
Compare
Found by an org-wide actionlint sweep. Per review feedback the lint tooling itself is staying in the core repos (compiler-explorer, infra, compiler-workflows) — this PR keeps just the fixes, which stand on their own:
🤖 Generated with Claude Code