Skip to content

Update deprecated GitHub Actions (checkout, setup-node v2 -> v4)#82

Merged
mattgodbolt merged 1 commit into
mainfrom
add-actionlint
Jul 12, 2026
Merged

Update deprecated GitHub Actions (checkout, setup-node v2 -> v4)#82
mattgodbolt merged 1 commit into
mainfrom
add-actionlint

Conversation

@mattgodbolt

@mattgodbolt mattgodbolt commented Jul 10, 2026

Copy link
Copy Markdown
Member

Found by an org-wide actionlint sweep. Per review feedback the lint tooling itself is staying in the core repos (compiler-explorer, infra, compiler-workflows) — this PR keeps just the fixes, which stand on their own:

  • actions/checkout v2 -> v4
  • actions/setup-node v2 -> v4

🤖 Generated with Claude Code

Copilot AI review requested due to automatic review settings July 10, 2026 21:16

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds GitHub Actions workflow linting via actionlint as part of an org-wide rollout, and updates existing workflows to use current major versions of core GitHub Actions.

Changes:

  • Add a new workflow to run actionlint when workflow/config files change.
  • Add an .github/actionlint.yaml configuration (runner labels + shellcheck gating).
  • Bump actions/checkout and actions/setup-node to v4 in the Node CI workflow.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
.github/workflows/node.js.yml Updates checkout/setup-node to v4 (but introduces/retains invalid steps: indentation that must be fixed).
.github/workflows/lint-actions.yml Adds a workflow running actionlint on workflow/config changes.
.github/actionlint.yaml Adds actionlint configuration (self-hosted runner labels + shellcheck ignore rules).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines 21 to 25
steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v4
- name: Use Node.js ${{ matrix.node-version }}
uses: actions/setup-node@v2
uses: actions/setup-node@v4
with:

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Declining — this is valid YAML. Block sequence entries may sit at the same indentation column as their parent mapping key (a "zero-indented" block sequence); it parses identically to the extra-indented form. This workflow has parsed and run in exactly this form for years, and actionlint — which uses a real YAML parser — passes it cleanly.

Comment thread .github/workflows/lint-actions.yml Outdated
Comment on lines +4 to +6
push:
branches: [main]
paths: ['.github/workflows/**', '.github/actionlint.yaml']
- actions/checkout v2 -> v4
- actions/setup-node v2 -> v4

Found by an org-wide actionlint sweep; the lint tooling itself is staying in the core repos only, but these fixes stand on their own.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@mattgodbolt mattgodbolt changed the title Lint GitHub Actions workflows with actionlint Update deprecated GitHub Actions (checkout, setup-node v2 -> v4) Jul 10, 2026
@mattgodbolt mattgodbolt merged commit 7039f59 into main Jul 12, 2026
2 checks passed
@mattgodbolt mattgodbolt deleted the add-actionlint branch July 12, 2026 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants