Feature/spinner - #11
Open
ericgozzi wants to merge 6 commits into
Open
Conversation
Adds a full-screen spinner shown while long-running backend work is in flight, driven by an inbound "spinner" viewer command (visible + optional message). Mirrors compas_threejs's existing App.start_spinner()/stop_spinner() convention on the Python side. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
… names The eslint-plugin-vue "multi-word-component-names" rule only grandfathers Openbar/Sidebar/Toolbar and the vendored shadcn-ui primitives; new components are expected to use multi-word names rather than be added to that exemption list. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new global Spinner component to the application, providing user feedback during long-running operations. It adds full support for a
Spinnercommand in the viewer command system, updates the documentation and support matrix, and ensures proper state management and validation for the spinner's visibility and message. The spinner displays a cycling "funny" message to improve the user experience during waits.Spinner Feature Implementation
Spinner.vuecomponent that displays a global overlay with an animated spinner, an optional message, and a rotating selection of humorous messages during long-running operations. The spinner is teleported to the document body for global visibility. (src/components/layout/Spinner.vue)Spinnercomponent into the main application layout and imported it inApp.vue. (src/App.vue) [1] [2]Viewer Command System Enhancements
SpinnerCommandtype, added it to theViewerCommandunion, and implemented parsing and validation logic for spinner commands. (src/viewer/viewer_commands.ts) [1] [2] [3] [4]src/viewer/viewer_runtime.ts) [1] [2] [3]spinnerStatefor managing the spinner's visibility and message. (src/viewer/viewer_store.ts) [1] [2]Documentation Updates
CHANGELOG.md)docs/support-matrix.md)Testing Adjustments
tests/viewer_commands.test.ts)