Write cached Singularity image resolution back to dockerImageId - #2317
Open
Sanjays2402 wants to merge 1 commit into
Open
Sanjays2402 wants to merge 1 commit into
Sanjays2402 wants to merge 1 commit into
Conversation
mr-c
approved these changes
Aug 1, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2317 +/- ##
==========================================
+ Coverage 85.06% 85.28% +0.22%
==========================================
Files 46 46
Lines 8626 8626
Branches 2021 2021
==========================================
+ Hits 7338 7357 +19
+ Misses 815 805 -10
+ Partials 473 464 -9 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
mr-c
approved these changes
Sep 14, 2026
When get_image() found the requested image id in the process-wide _IMAGES cache, it stored the resolved path under "dockerImage_id", a field that is never read anywhere. get_from_requirements() and the sandbox path both read "dockerImageId", so the cached resolution was silently discarded and the unresolved id was used instead. Write the resolved value back to "dockerImageId", matching the other cache interaction at the end of get_image(). Adds a regression test that seeds _IMAGES with a resolved path and asserts the requirement's dockerImageId is updated.
mr-c
force-pushed
the
fix/singularity-cached-image-id
branch
from
September 14, 2026 12:01
c752815 to
617d945
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2283
When
get_image()hits the_IMAGEScache it wrote the resolved image todockerRequirement["dockerImage_id"], but nothing ever reads that field —get_from_requirements()and the sandbox path both readdockerImageId, so the cached resolution was discarded and the unresolved id was used. Writes it back todockerImageId, matching the cache update at the end of the same method.Regression test seeds
_IMAGESwith a resolved path and asserts the requirement is updated; it fails on master and passes with the change.