fix: preserve original commit message content in get_pr_commit_messages()#190
Merged
shenxianpeng merged 2 commits intobugfix/issue-184from Mar 16, 2026
Merged
Conversation
…sages Co-authored-by: shenxianpeng <3353385+shenxianpeng@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] [WIP] Address feedback on PR commit message retrieval and validation implementation
fix: preserve original commit message content in get_pr_commit_messages()
Mar 16, 2026
shenxianpeng
approved these changes
Mar 16, 2026
shenxianpeng
approved these changes
Mar 16, 2026
shenxianpeng
pushed a commit
that referenced
this pull request
Mar 16, 2026
shenxianpeng
added a commit
that referenced
this pull request
Apr 20, 2026
* feat: implement PR commit message retrieval and validation in commit-check * fix: correct variable names in subprocess calls for clarity * fix: get original commit message content in get_pr_commit_messages() (#190) * chore: Update commit-check version to 2.4.3 * feat: Enable autofix for pull requests in pre-commit config * feat: refactor commit-check logic and add unit tests for new functionality * fix: format list comprehensions for better readability in get_pr_commit_messages() and related tests * fix: add args to codespell hook to ignore specific words * fix: update main_test.py * fix: improve error handling and return codes in commit message checks * fix: auto fixes from pre-commit.com hooks * refactor: clean up PR commit validation flow * chore: auto fixes from pre-commit.com hooks * refactor: clean up PR commit validation flow * chore: auto fixes from pre-commit.com hooks * feat: enhance commit message checks with section separators and no-banner option * fix: update commit message formatting to improve output clarity and consistency * chore: auto fixes from pre-commit.com hooks * fix: simplify output handling in PR message checks and update test assertions * fix: update output formatting in PR message checks to include commit indexing --------- Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
get_pr_commit_messages()was callingstrip()on each commit message, silently modifying content before passing it tocommit-checkfor validation — masking real formatting violations like leading/trailing spaces.Changes
main.py:57: Replacestrip()withrstrip("\n")to only trim the trailing newline artifact fromgit log --pretty=format:%B%x00output, preserving the original message contentm.strip()tom.rstrip("\n")for consistency, correctly excluding empty NUL-terminator entries without discarding whitespace-only content📱 Kick off Copilot coding agent tasks wherever you are with GitHub Mobile, available on iOS and Android.