Regression fixes and prepare 0.2.0#121
Open
refi64 wants to merge 9 commits into
Open
Conversation
Since our on_event was skipping the inner filter, the disabled bits would stay set for the next event, which coincidentally could end up being an event logged with `gitlab.output=true` directly. This seems to not have come up in testing because the events that got accidentally disabled were TRACE events that we didn't really care about anyway. The tests are also modified to only enable TRACE-level logging when OBO_TEST_TRACE is set, that way the tests are doing logging with a setup more similar to the runner proper.
Since the CLI trace logs end up in the same place as the output logs, we need a small hack to differentiate them in one test, but it's only enabled when test tracing is enabled and thus shouldn't cause problems elsewhere.
gitlab-runner 0.0.8+ adds support for artifact filtering, which we were preparing for here...but the current syntax does not actually match GitLab's own syntax and instead treats the patterns as globs for individual files (not directories). Thus, we need to turn the results directory name into a glob in order for them to actually be uploaded as artifacts.
Otherwise, generated pipelines might end up with bad `artifacts` items without it being caught during testing.
refi64
force-pushed
the
wip/refi64/prep-0.2.0
branch
from
36e5d02 to
3ee5231
Compare
This contains fixes for recent GitLab versions: https://docs.gitlab.com/releases/patches/patch-release-gitlab-19-0-2-released/ Fixes #119.
This contains a fix for infinite looping when downloading the logs when reqwest uses HTTP/2.
This isn't a complete integration test or similar, but it can run a simple "pipeline" with either the CLI or the runner and then grab and display the resulting artifacts.
This makes it easier to bump the version for the CLI + runner and reduces duplication.
refi64
force-pushed
the
wip/refi64/prep-0.2.0
branch
from
3ee5231 to
6f6123e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contains the gitlab-runner upgrade to work with newer GitLab, plus three regression fixes for the runner:
generate-pipelineto use syntax compatible with the current gitlab-runner version.The latter two should now be caught via the test suite, and the first should be caught by the newly added, vaguely horrifying smoke test bash script.