Skip to content

Add support to exclude architectures and repositories#111

Merged
refi64 merged 2 commits into
collabora:mainfrom
wlozano0collabora:wip/wlozano/exludes
May 11, 2026
Merged

Add support to exclude architectures and repositories#111
refi64 merged 2 commits into
collabora:mainfrom
wlozano0collabora:wip/wlozano/exludes

Conversation

@wlozano0collabora
Copy link
Copy Markdown
Contributor

In some use cases it is useful to exclude architectures and repositories as those builds should not block a pipeline. To allow that add a set of new arguments to dput.

@wlozano0collabora wlozano0collabora force-pushed the wip/wlozano/exludes branch 2 times, most recently from 79d3165 to 7024da2 Compare May 8, 2026 17:34
Comment thread obo-core/src/actions.rs Outdated
Comment thread obo-core/src/actions.rs Outdated
Comment thread obo-core/src/build_meta.rs Outdated
Comment thread obo-core/src/build_meta.rs
@wlozano0collabora wlozano0collabora force-pushed the wip/wlozano/exludes branch 6 times, most recently from 75a3cba to acfd951 Compare May 9, 2026 11:15
@sjoerdsimons sjoerdsimons requested a review from Copilot May 9, 2026 11:18
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds optional architecture/repository exclusion lists to the dput workflow so specific builds can be ignored and won’t block the pipeline.

Changes:

  • Extend BuildMetaOptions with exclude_arch / exclude_repo filters and apply them when enumerating repo/arch build targets.
  • Add --exclude-arch and --exclude-repo CLI arguments to dput and pass them into BuildMeta retrieval.
  • Expand BuildMeta tests to cover exclusion behavior and multi-repo scenarios.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
obo-test-support/src/lib.rs Adds an extra test repository constant to support new exclusion-related tests.
obo-core/src/build_meta.rs Implements exclude filtering in metadata collection and extends test coverage for excluded arches/repos.
obo-core/src/actions.rs Adds new dput CLI flags and wires them into BuildMetaOptions.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread obo-core/src/actions.rs
In some use cases there is no point in monitoring for architectures
as the build status should not block a pipeline. To support these
scenarios implement a new argument for dput to exclude architectures.

Signed-off-by: Walter Lozano <walter.lozano@collabora.com>
In some use cases there is no point in monitoring for repositories
as the build status should not block a pipeline. To support these
scenarios implement a new argument for dput to exclude repos.

Signed-off-by: Walter Lozano <walter.lozano@collabora.com>
@refi64 refi64 added this pull request to the merge queue May 11, 2026
Merged via the queue into collabora:main with commit 9408963 May 11, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants