Add isClean entity state checks - #344
Open
elpete wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #50
Issue review
Recommendation: 10/10 — implement.
isCleanmakes the inverse state check readable and avoids repeated negation throughout consuming applications. Supporting one alias or column is especially useful for conditional work tied to a specific field. This is additive and low risk.Implementation
isClean()for whole-entity stateisClean(attribute)for a Quick alias or physical columnisDirtyTest-first evidence
The public regression initially errored with
QuickMissingMethod. It now covers a fully clean entity, clean alias and physical-column checks, whole-entity dirtiness after a change, the changed field becoming unclean, and an unrelated field remaining clean.Review note
This PR is independently mergeable against
next. PR #343 adds the complementary optional-attribute support toisDirty; if both are merged, a small follow-up refactor could share their per-attribute comparison helper, but neither PR depends on the other.Validation
box run-script formatgit diff --checkUses
qb@14.0.0-beta.3.