Add touch for entity timestamps - #341
Open
elpete wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #53
Issue review
Recommendation: 7/10 — implement. A
touch()helper is a familiar, concise way to update an entity timestamp without manually setting it. It is especially useful for cache invalidation and recording activity that does not otherwise change attributes. The issue has no detailed body, so this PR intentionally implements the small Eloquent-style entity operation rather than automatic timestamps or relationship cascading.The tradeoff is that
touch()uses the normal save lifecycle and therefore persists any other dirty attributes on the entity as well.Implementation
touch(attribute="modifiedDate", options={})to loaded entitiesTest-first evidence
The public regression initially errored with
QuickMissingMethod. It now verifies the in-memory timestamp advances, the entity is clean after touching, and a fresh database read contains the advanced timestamp.Validation
box run-script formatgit diff --checkUses
qb@14.0.0-beta.3.