Add built-in soft delete support - #340
Open
elpete wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #54
Issue review
Recommendation: 9/10 — implement. Soft deletes are common enough that every application should not have to rebuild the same global scope and lifecycle methods. A metadata-driven implementation fits Quick’s entity model. The tradeoffs are an additional nullable timestamp column, behavior changes for
delete/deleteAllon opted-in entities, and the need to choose permanent deletion explicitly.Implementation
Configure an entity with
softDeletes=true, optionally setsoftDeleteColumn(defaultdeletedAt), and define that property. The feature adds:withTrashed()andonlyTrashed()query controlsdelete(),restore(),trashed(), andforceDelete()behaviordeleteAll(),restoreAll(), andforceDeleteAll()behaviorTest-first evidence
The end-to-end public regression initially failed because
delete()permanently removed the entity and marked it unloaded. It now covers default visibility, querying trashed rows, restoring, soft bulk deletion/restoration, and permanent entity/bulk deletion.The first full suite exposed two missing post-delete event assertions after the delete refactor; those were fixed before opening this PR.
Validation
box run-script formatgit diff --checkUses
qb@14.0.0-beta.3.