Refresh database-generated attributes on save - #338
Open
elpete wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #58
Issue review
Recommendation: 9/10 — implement. Database-generated timestamps, computed columns, and trigger-updated values are common, and requiring callers to remember a separate
refresh()leaves saved entities stale. A property-level opt-in keeps the extra query explicit. The tradeoff is one additional select for saves on entities that use the flag.Implementation
refreshOnSave(defaultfalse)Test-first evidence
The public save regression initially errored because the database-default
created_dateremained null on the saved entity. WithrefreshOnSave=true, the entity receives the database timestamp immediately and remains clean.Validation
box run-script formatgit diff --checkUses
qb@14.0.0-beta.3.