Test Quick with Lucee full null support - #333
Open
elpete wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #64
Issue review
Recommendation: 10/10 — implement. Full null support changes how database nulls are represented at Quick’s public boundaries, so exercising this mode in CI is a strong fit. It catches compatibility regressions that the default Lucee configuration necessarily hides. The tradeoff is one additional Lucee job per ColdBox matrix entry and null-mode-aware assertions where the two engine modes intentionally differ.
Implementation
lucee.full.null.support=trueTest-first evidence
The first full-null baseline reproduced seven failing assertions (and zero errors) where tests assumed Lucee would coerce database nulls to empty strings. The assertions were updated to validate each mode’s intentional public behavior.
Validation
box run-script formatgit diff --checkUses
qb@14.0.0-beta.3.