Surface missing methods inside qb callbacks - #319
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #142
Issue review
This is a valid error-reporting bug and a strong fit for Quick. The public call is
when, but the actionable failure occurs on the Quick-aware builder passed to its callback. Reporting the wrapper method forces developers to read a nested message and can make a supported qb method look broken.Recommendation: 9/10 — implement.
Reasons for:
whenQuickMissingMethodtext and underlying qb exception detailsTradeoffs:
QuickQBnow becomeQuickMissingMethodat that boundary instead of bubbling asQBMissingMethodto an outer wrapperReproduction and fix
The regression was written first through the public Quick API:
getInstance( "User" ).when( true, function( q ) { q.missingScopeInsideWhen(); } );With the current
qb 14.0.0-beta.3, the test failed because the top-level message said Quick could not handle[when]; the actual[missingScopeInsideWhen]error was nested later in the message.QuickQB.onMissingMethodnow converts qb's terminal missing-method exception at the point where the inner method name is still known. The outer entity handler therefore receives the already-actionable Quick exception and does not relabel it aswhen.Validation
git diff --checkpassed