device: Fix wgpuDeviceRelease() being called when releasing other objects#20
Closed
obiwac wants to merge 1 commit intocogentcore:mainfrom
Closed
device: Fix wgpuDeviceRelease() being called when releasing other objects#20obiwac wants to merge 1 commit intocogentcore:mainfrom
wgpuDeviceRelease() being called when releasing other objects#20obiwac wants to merge 1 commit intocogentcore:mainfrom
Conversation
|
This is on purpose. e.g. look at your first change for buffers. in This is done to simplify calling of some buffer related methods that would otherwise require you to pass the device again. |
Member
|
Ok so based on @oliverbestmann comments I'm going to close this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A little confused about why this was being done in the first place - the fact that it's being done in multiple object release functions leads me to believe this was somehow intentional, but I really can't figure out why.
Either way, putting this PR up because it fixes texture freeing invalidating the device for a project of mine.