Network preference for the order of communities in the dashboard and dropdown - #2143
Network preference for the order of communities in the dashboard and dropdown#2143MoshiKoi wants to merge 10 commits into
Conversation
52f17d6 to
3a556aa
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files
☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
I like the draggable handles. I think for many people that will be the easiest way to rearrange the communities. Could we keep the handles and also add up and down buttons (that shift that community one place in that direction)? Some people may find up and down buttons more convenient, but also some people cannot drag (for various reasons). See Dragging Movements accessibility guidance. If both draggable handles and up and down buttons take up too much space, there's also the possibility of having up and down buttons only appear when a draggable handle is clicked/tapped rather than dragged. Personally I'd prefer up and down buttons that are always visible to aid discoverability. |
8ff0145 to
f397525
Compare
First take at #1323, testing and feedback welcome
This PR adds a new preference type for the community preference, as well as a separate "block preference" for styling purposes since it didn't make much sense trying to cram it into the horizontal layout the other preferences use. The styling is very much a work in progress, but it is functional right now.
You can reorder the communities by dragging.
I pulled in JQuery-UI for this - not entirely sure if it's worth bringing it in as a dependency, but it can be replaced if needed.I have switch to SortableJS to avoid depending on jQuery.Might try to also implement "collapsed" communities (#1993). Not sure if that has any real added value if it just sends communities to the bottom since users can do that anyway, but it might be useful as a foundation for later work if we want users to, for instance, be able to set up an email subscription of "posts from focused communities" or similar mechanism.