Let any present widget contribute frontend packs#2443
Merged
Conversation
Generalize the scrolled widget-to-pack mechanism: instead of only ReactWidgetType (insert_point :react) contributing a single pack, collect packs from any present widget whose type responds to packs(entry:, request:, **). This lets widgets at other insert points (e.g. the server-rendered analytics widget) selectively contribute packs, gated by widget presence, and threads the request so packs can depend on it. ReactWidgetType now implements packs; the editor path collects from all editor-enabled widget types, the frontend path from the entry's present widgets. REDMINE-21330
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generalize the scrolled widget-to-pack mechanism: instead of only ReactWidgetType (insert_point :react) contributing a single pack, collect packs from any present widget whose type responds to packs(entry:, request:, **). This lets widgets at other insert points (e.g. the server-rendered analytics widget) selectively contribute packs, gated by widget presence, and threads the request so packs can depend on it.
ReactWidgetType now implements packs; the editor path collects from all editor-enabled widget types, the frontend path from the entry's present widgets.
REDMINE-21330