Skip to content

feat(coder/modules/boundary): add boundary module#840

Open
35C4n0r wants to merge 14 commits intomainfrom
35C4n0r/feat-boundary-module
Open

feat(coder/modules/boundary): add boundary module#840
35C4n0r wants to merge 14 commits intomainfrom
35C4n0r/feat-boundary-module

Conversation

@35C4n0r
Copy link
Copy Markdown
Collaborator

@35C4n0r 35C4n0r commented Apr 13, 2026

Description

Extracts boundary installation and wrapper logic into a standalone coder/boundary module, decoupling it from agentapi.

Why

Boundary is currently embedded inside agentapi (scripts/boundary.sh) and duplicated in claude-code. This couples network isolation to the AI/Tasks stack, but boundary is a general-purpose primitive — users running a plain agent with no agentapi or tasks should be able to use it too.

What this adds

registry/coder/modules/boundary/ — a new first-class module that:

  • Installs boundary via one of three strategies:
    1. coder boundary subcommand (default, zero-install)
    2. Direct binary from release (use_boundary_directly = true)
    3. Compiled from source (compile_boundary_from_source = true)
  • Creates a wrapper script at $HOME/.coder-modules/coder/boundary/boundary-wrapper.sh
  • Exports AGENTAPI_BOUNDARY_PREFIX as a coder_env so any workspace process can use it
  • Strips CAP_NET_ADMIN from the coder binary (copies to coder-no-caps) to allow execution inside network namespaces without sys_admin
  • Supports pre_install_script / post_install_script hooks
  • Exposes boundary_wrapper_path output and sync_script_names for script coordination

Usage

module "boundary" {
  count    = data.coder_workspace.me.start_count
  source   = "registry.coder.com/coder/boundary/coder"
  version  = "1.0.0"
  agent_id = coder_agent.main.id
}

Works standalone with any agent — no agentapi dependency required.

Testing

  • Terraform variable validation (boundary.tftest.hcl)
  • TypeScript integration tests (main.test.ts): state verification, coder subcommand happy path, custom hooks, env var correctness, wrapper execution, idempotent installation

Type of Change

  • New module

Module Information

Path: registry/coder/modules/boundary
New version: v1.0.0
Breaking change: No

Related Issues

Closes #844

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a new coder/boundary registry module intended to set up Boundary-related tooling for Coder workspaces.

Changes:

  • Introduces a Boundary install/setup shell script that can compile from source, install from release, or rely on coder boundary.
  • Adds a Terraform module (main.tf) that deploys and runs the install script on an agent.
  • Adds module README and Terraform native tests (.tftest.hcl).

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 7 comments.

File Description
registry/coder/modules/boundary/scripts/install.sh Installs Boundary (or validates coder boundary) and generates a wrapper script.
registry/coder/modules/boundary/main.tf Defines module variables and a coder_script to deliver/execute install.sh.
registry/coder/modules/boundary/README.md Documents module usage and examples.
registry/coder/modules/boundary/boundary.tftest.hcl Adds Terraform plan-time assertions for basic module wiring.

Comment thread registry/coder/modules/boundary/scripts/install.sh
Comment thread registry/coder/modules/boundary/scripts/install.sh Outdated
Comment thread registry/coder/modules/boundary/scripts/install.sh
Comment thread registry/coder/modules/boundary/scripts/install.sh
Comment thread registry/coder/modules/boundary/scripts/install.sh
Comment thread registry/coder/modules/boundary/main.tf Outdated
Comment thread registry/coder/modules/boundary/README.md
@35C4n0r 35C4n0r marked this pull request as draft April 13, 2026 03:38
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated 7 comments.

Comment on lines +61 to +62
source = "git::https://github.com/coder/registry.git//registry/coder/modules/coder-utils?ref=feat/coder-utils-optional-install-start"
# version = "1.0.1"
Copy link

Copilot AI Apr 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This module depends on coder-utils via a Git source pinned to a feature branch (ref=feat/coder-utils-optional-install-start). For a published registry module, this is brittle (branch rename/deletion breaks installs) and makes upgrades non-reproducible. Prefer depending on a tagged release/commit SHA (or a registry-published module version) and remove the commented-out version line once a stable version is available.

Suggested change
source = "git::https://github.com/coder/registry.git//registry/coder/modules/coder-utils?ref=feat/coder-utils-optional-install-start"
# version = "1.0.1"
source = "coder/coder-utils/coder"
version = "1.0.1"

Copilot uses AI. Check for mistakes.
Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will be resolved later

Comment thread registry/coder/modules/boundary/main.tf Outdated
Comment thread registry/coder/modules/boundary/main.test.ts Outdated
Comment thread registry/coder/modules/boundary/testdata/boundary-mock.sh Outdated
Comment thread registry/coder/modules/boundary/scripts/install.sh
Comment thread registry/coder/modules/boundary/scripts/install.sh Outdated
Comment thread registry/coder/modules/boundary/scripts/install.sh
Jay Kumar and others added 8 commits April 14, 2026 18:19
…missing mock support

Three root causes:

1. boundary_script_destination used 'install.sh' - same filename that coder-utils
   writes to. This caused the running script to overwrite itself, corrupting
   bash's incremental read and producing empty install.log / no wrapper.
   Fix: rename to 'boundary-install.sh'.

2. coder-mock.sh didn't handle 'coder exp sync' commands used by coder-utils
   for script ordering. With set -o errexit, scripts failed immediately.
   Fix: add exp sync as no-op (exit 0).

3. Test setup used setupUtil which only extracts ONE coder_script, but
   coder-utils creates multiple (pre_install, install, post_install).
   Fix: extract all coder_scripts from terraform state and run them
   sequentially in lifecycle order.

4. wrapper-script-execution test called 'wrapper.sh --help' which the mock
   couldn't handle after the '--' separator (tried to exec '--help').
   Fix: test with 'echo boundary-test' instead.
The boundary command (both 'coder boundary' and standalone 'boundary')
expects a '--' separator before the command to execute. The wrapper
scripts were passing arguments directly without this separator, causing
the wrapper-script-execution test to fail.

🤖 Generated by Coder Agents
The boundary wrapper scripts pass arguments directly without a '--'
separator. Updated the coder mock to match this behavior and adjusted
the test comment accordingly.

🤖 Generated by Coder Agents
@35C4n0r 35C4n0r marked this pull request as ready for review April 15, 2026 17:27
@matifali matifali requested review from SasSwart, dannykopping and jcjiang and removed request for matifali April 16, 2026 04:50
@SasSwart
Copy link
Copy Markdown

Review request acknowledged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Decouple boundary into its own standalone module

3 participants