🤖 fix: drop the creation headline and align docked surfaces with the transcript column - #3758
Merged
Conversation
Contributor
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. Keep it up! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
…nscript The "Let's get building." headline gave a static string the largest type on the creation page, so remove it. The composer dock cancels the transcript scrollport's gutter so it can paint full-bleed, and every surface inside it re-applied that gutter as px-4 (16px) with a hardcoded max-w-4xl column. In full-width mode the transcript is no longer capped, so the composer, its decorations, and the warning banners stayed 896px wide inside a much wider transcript. Share the gutter and the width mode through one hook so docked surfaces track the transcript column in both modes.
Review of the first commit found three dock entries it missed: the compaction warning and context-switch banner carried their own mx-4, and the pre-stream task card had no gutter at all, so none of them tracked the transcript column in either width mode. Wrap all three in a ChatDockSurface. Resolve the width mode through a context the dock provides rather than calling the preference hook per surface, since that hook also fetches and subscribes to the backend config.
ibetitsmike
force-pushed
the
mike/chat-column-alignment
branch
from
July 29, 2026 15:31
f15c692 to
0d8e932
Compare
Contributor
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. Keep them coming! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the "Let's get building." headline from the creation page, and lines every surface in the composer dock up with the transcript column so the composer stops floating in the middle of a full-width transcript.
Background
Both reported from the chrome redesign in #3753. Rebased onto
mainnow that #3757 has merged, so this diff is only the two commits below.The headline gave a static string the largest type on the page. It was already
sr-onlybelow 768px, so this removes it outright.The alignment bug is structural. The composer dock lives inside the transcript scrollport and cancels its
px-[15px]gutter withmx-[-15px]so it can paint full-bleed. Every surface inside the dock therefore has to re-apply that gutter and follow the transcript's width mode. They all hardcodedpx-4(16px) plusmx-auto max-w-4xlinstead.Centered mode hid this completely: the transcript and the docked surfaces shared both a center line and the same
4xlcap, so their edges coincided by accident. Turn onchatTranscriptFullWidthand the transcript uncaps while everything docked stays 896px wide.Implementation
CHAT_DOCK_GUTTER_CLASS(inconstants/layout) plusChatDockColumnProvider/useChatDockColumnWidthClass/ChatDockSurface(incomponents/ChatPane/chatDockColumn) now carry the contract. The dock provides the width mode; surfaces inside consume it.Applied to the composer section,
ChatInputDecoration(todos, background bashes, reviews, queued messages, chat instructions),ConcurrentLocalWarningDecoration, andTranscriptOnlyNoticePane. The second commit sweeps three decoration-lane entries that never followed the column in either mode: the compaction warning and context-switch banner carried their ownmx-4, and the pre-stream task card had no gutter at all. All three go throughChatDockSurface, and the twomx-4values are removed so the wrapper is the single source of the inset.The width mode resolves through context rather than calling
useChatTranscriptFullWidthper surface, because that hook also issues aconfig.getConfigfetch and anonConfigChangedsubscription per instance, and the dock can hold several decorations at once.Validation
Measured at 1500px with the left sidebar collapsed: in full-width mode the transcript rows, composer box, background-bash decoration, and auto-compact label all span 35..1465; centered, all cap at 896.
Two play tests (
FullWidthTranscriptAlignment,CenteredTranscriptAlignment) assert every docked surface shares the transcript column's left and right edges, including eachChatDockSurface-wrapped entry. Four red-green toggles:Docked composer is inset ... by 157px left and 157px rightpx-4... by 1px left and 1px rightNo ChatDockSurface-wrapped entry renderedTranscript is 896px wide, so this story is not in full-width modeThe centered story separately asserts the scrollport has room to exceed the cap, so it proves the cap is what limits the column rather than the available width.
One trap worth recording:
updatePersistedState(CHAT_TRANSCRIPT_FULL_WIDTH_KEY, true)does not enable full width in a story, becauseuseChatTranscriptFullWidthsyncs fromconfig.getConfigand overwrites it. The story would silently run centered and pass with the bug present.setupSimpleChatStorynow takeschatTranscriptFullWidthand threads it to the mock config.Risks
Expect Pixel diffs on any story showing the compaction warning, context-switch banner, or pre-stream task card: those move from a 16px full-bleed inset onto the composer column, which is the intended correction.
Not fixed here, pre-existing and unrelated to width mode: in centered mode the composer's toast overlay is positioned against the outer section rather than the inner column, so it spans nearly the whole dock. Moving its containing block would also shift it vertically, so it needs its own change.
Generated with
mux• Model:anthropic:claude-opus-5• Thinking:xhigh