🤖 docs: update the Terminating namespace step after the #209 fix - #219
Conversation
The troubleshooting step still said that a namespace without an eligible control plane never finishes deleting. #214 fixed that for a namespace without any control plane. The step now links the reference section and names the two cases that still answer the list with 503: a control plane that is not eligible, until the namespace controller deletes it, and a standalone server without Coder credentials (#215). Refs #209 Refs #215 Signed-off-by: Thomas Kosiewski <tk@coder.com> --- _Generated with [`xum`](https://github.com/coder/xum) • Model: `anthropic:claude-opus-5-5` • Thinking: `high`_ Change-Id: I6392df4a7a310671ef5b0bb06970e09ba16de436
|
@codex review |
|
@codex security review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
🛡️ Codex Security ReviewSecurity review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b015cf27b6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Review found four gaps in the rewritten step. The namespace controller lists only coderworkspaces and codertemplates, because codertemplateversions has no delete verb. The empty list applies to namespaces without a Coder backend in each app mode, as the reference defines them, and the pinned standalone namespace returns what Coder holds. A control plane whose operator token Secret lacks the key or holds an empty value also returns 503. A standalone server answers 503 only without both its URL and token, and does not start when only one is missing. Refs #209 Refs #215 Signed-off-by: Thomas Kosiewski <tk@coder.com> --- _Generated with [`xum`](https://github.com/coder/xum) • Model: `anthropic:claude-opus-5-5` • Thinking: `high`_ Change-Id: Iedda13df230ae69d834f9db07216015f9fb37b26
|
@codex review |
|
@codex security review |
🛡️ Codex Security ReviewSecurity review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9adbb8ac9e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Each review round added cases to step 2, and each case drew new findings. The step now tells the reader to read the NamespaceDeletionContentFailure message, links the reference and the ServiceUnavailable entry for what each error means, and points to the control plane's finalizers and the controller logs. It no longer lists cases, and it drops the standalone --coder-namespace note. Refs #209 Refs #215 Signed-off-by: Thomas Kosiewski <tk@coder.com> --- _Generated with [`xum`](https://github.com/coder/xum) • Model: `anthropic:claude-opus-5-5` • Thinking: `high`_ Change-Id: I6ec365ecd630d27daa03923e36f5963ab739da6f
|
@codex review |
|
@codex security review |
🛡️ Codex Security ReviewSecurity review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: cfc8e162ac
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
1 participant
Summary
The troubleshooting step "A namespace stays
Terminating" still said that #209 makes a namespace without an eligible control plane hang forever. #214 fixed that for a namespace that has noCoderControlPlaneat all: the aggregated API now answers its list with an empty list.What
Step 2 of the section is now three short sentences and two commands, with no list of cases:
NamespaceDeletionContentFailureisTrue, read its message. It contains the error that the aggregated API returned for the namespace controller's list, for example a503or a400.ServiceUnavailable" entry.CoderControlPlaneis still in the namespace, check its finalizers (for examplecoder.com/workspace-rbac-cleanup) and the controller logs.The note that #214 added under "Aggregated reads return
ServiceUnavailable" stays as it is. This change does not repeat it.Review rounds
Validation
On the pushed tree:
make docs-check(strict build),markdownlint-cli20.18.1, andcspell8.19.4, each with exit 0. The built page contains both new links.Refs #209
Refs #215
Generated with
xum• Model:anthropic:claude-opus-5-5• Thinking:high