Skip to content

Fix DesktopMode iOS screenshot late-present race (700ms -> 1500ms settle) #5316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
shai-almog wants to merge 1 commit into
base: master
Choose a base branch
from
+6 −3
Open

Fix DesktopMode iOS screenshot late-present race (700ms -> 1500ms settle) #5316

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions .../main/java/com/codenameone/examples/hellocodenameone/tests/DesktopModeScreenshotTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,11 +108,14 @@ public boolean runTest() throws Exception {
/// The 30-row scrollable form is heavy enough that on the iOS Metal backend
/// its first frame is occasionally presented just after the capture fires,
/// so Display.screenshot() reads the previous test's framebuffer and this
/// test "captures the wrong form". Force a repaint and a short extra settle
/// so the DesktopMode form is fully presented before the screenshot.
/// test "captures the wrong form". Force a repaint and an extra settle so the
/// DesktopMode form is fully presented before the screenshot. 700ms still lost
/// the race on a starved CI runner (the capture showed the preceding
/// MutableImageClip form), so use the same 1500ms margin the OrientationLock
/// test relies on for its post-rotation present.
@Override
protected long extraSettleBeforeCaptureMillis() {
return 700;
return 1500;
}

@Override
Expand Down
Loading