Address #3695 using data-codemirror-linenumber and CSS content

[colelawrence]

This addresses the open issue: #3695

The code presented is linted, and all tests were passed.

You may view a demo with changes off my gh-pages branch

Please provide feedback on recommended changes or styles.

[danth]

Everything looks good to me. All coding styles are the same as surrounding code, there are no obvious errors.

---

Reviewed 2 of 2 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved, some commit checks failed.

---

Comments from Reviewable

[adrianheine]

This would have to be rebased since I split lib/codemirror.js a year ago.

[marijnh]

I think this is too invasive. The plan is to eventually, in a breaking version, move all line gutter content to a separate container so that they don't muddle up the code's DOM.

[colelawrence]

@marijnh I agree that a change like this should probably be considered for a major release as it could break a plugin that depends on reading the DOM structure for line numbers.

I wonder if just using CSS user-select: none could also address this...

[marijnh]

I wonder if just using CSS user-select: none could also address this...

Unfortunately, no. That'll hide the selection markers, but still copy the text on at least some browsers.

[colelawrence]

Ah, okay. That's right, I had forgotten that effect.

…

On Fri, Oct 20, 2017, 10:53 AM Marijn Haverbeke ***@***.***> wrote: I wonder if just using CSS user-select: none could also address this... Unfortunately, no. That'll hide the selection markers, but still copy the text on at least some browsers. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#3696 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ACyjUw7-xH6awVissTAegxns97iFr-BDks5suMHtgaJpZM4Gy_sP> .