Conversation
The validateRecaptcha() function is async and returns a Promise<boolean>, but was called without await on both the checkout login form and the main login form. Since a Promise object is always truthy, !Promise is always false, which meant the reCAPTCHA check was effectively bypassed. This fix adds the missing await keyword so reCAPTCHA validation actually runs when reCAPTCHA env vars are configured.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix
Adds missing
awaitkeyword beforevalidateRecaptcha()calls in both:apps/web/components/public/payments/login-form.tsx)apps/web/app/(with-contexts)/(with-layout)/login/login-form.tsx)Problem
The
validateRecaptcha()function isasyncand returns aPromise<boolean>, but was called withoutawait. Since a Promise object is always truthy,!Promiseis alwaysfalse, meaning the reCAPTCHA check was silently bypassed even when reCAPTCHA env vars were configured.Testing
Fixes #688