Repository navigation
feat: Allow RawSql JOIN tables (#9070) - #10571
wakqasahmed wants to merge 3 commits into
Conversation
|
The updated JOIN regressions pass locally (16 tests), and the review fix is in 9d63234. The Oracle CI job failed in the randomized AutoReview test |
michalsn
left a comment
There was a problem hiding this comment.
I think it looks good. But please update the join signature in Model.php.
michalsn
left a comment
There was a problem hiding this comment.
Thank you. Please rebase to fix the PHPStan error.
530b374 to
f3ef499
Compare
|
Rebased onto 4.8 (same for #10574). The earlier PHPStan errors are gone. The one left is in |
Description
RawSqlas the JOIN table, including in the Postgre and SQLSRV builders.The new base test failed with the original
TypeErrorbefore the change. The local PHP image has no coverage driver, so coverage is left to CI.Closes #9070.
Test plan:
JoinTest.php(14 tests)Checklist: