refactor: lazily load CSP and Cookie only when needed by Response#10121
Open
paulbalandan wants to merge 2 commits intocodeigniter4:4.8from
Open
refactor: lazily load CSP and Cookie only when needed by Response#10121paulbalandan wants to merge 2 commits intocodeigniter4:4.8from
paulbalandan wants to merge 2 commits intocodeigniter4:4.8from
Conversation
michalsn
reviewed
Apr 18, 2026
michalsn
approved these changes
Apr 18, 2026
neznaika0
reviewed
Apr 19, 2026
| * Called by every cookie-related method so cookie machinery is only | ||
| * loaded when the developer actually interacts with cookies. | ||
| */ | ||
| private function initializeCookieStore(): CookieStore |
Contributor
There was a problem hiding this comment.
A small clarification: for initialization, it is not necessary to return something (void). If you use return for the call chain, perhaps you should rename it to getCookieStore()?
Member
Author
There was a problem hiding this comment.
Thanks, you're right!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes #8201
Checklist: