fix: ensure output buffer is closed after use of command()#10099
Merged
paulbalandan merged 1 commit intocodeigniter4:developfrom Apr 10, 2026
Merged
fix: ensure output buffer is closed after use of command()#10099paulbalandan merged 1 commit intocodeigniter4:developfrom
command()#10099paulbalandan merged 1 commit intocodeigniter4:developfrom
Conversation
a4a376e to
74b1d92
Compare
michalsn
reviewed
Apr 10, 2026
Member
michalsn
left a comment
There was a problem hiding this comment.
Looks good, but we need a changelog entry.
74b1d92 to
5ff30a2
Compare
Member
Author
Thanks. Added changelog. |
michalsn
approved these changes
Apr 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When the command run through
command()throws, output buffering is not closed, causing risky tests in phpunit.Checklist: