Skip to content

fix: ensure output buffer is closed after use of command()#10099

Merged
paulbalandan merged 1 commit intocodeigniter4:developfrom
paulbalandan:fix-command-output-buffer
Apr 10, 2026
Merged

fix: ensure output buffer is closed after use of command()#10099
paulbalandan merged 1 commit intocodeigniter4:developfrom
paulbalandan:fix-command-output-buffer

Conversation

@paulbalandan
Copy link
Copy Markdown
Member

Description
When the command run through command() throws, output buffering is not closed, causing risky tests in phpunit.

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value (without duplication)
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@paulbalandan paulbalandan added the bug Verified issues on the current code behavior or pull requests that will fix them label Apr 10, 2026
@paulbalandan paulbalandan force-pushed the fix-command-output-buffer branch from a4a376e to 74b1d92 Compare April 10, 2026 12:59
Copy link
Copy Markdown
Member

@michalsn michalsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but we need a changelog entry.

@paulbalandan paulbalandan force-pushed the fix-command-output-buffer branch from 74b1d92 to 5ff30a2 Compare April 10, 2026 14:04
@paulbalandan
Copy link
Copy Markdown
Member Author

Looks good, but we need a changelog entry.

Thanks. Added changelog.

@paulbalandan paulbalandan merged commit 8ca64a9 into codeigniter4:develop Apr 10, 2026
60 of 61 checks passed
@paulbalandan paulbalandan deleted the fix-command-output-buffer branch April 10, 2026 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Verified issues on the current code behavior or pull requests that will fix them

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants