fix: store SPL closures in register() so unregister() can remove them#10097
Merged
michalsn merged 1 commit intocodeigniter4:developfrom Apr 9, 2026
Merged
Conversation
paulbalandan
approved these changes
Apr 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixed a bug where
Autoloader::unregister()could fail to remove handlers from the SPL autoload stack during tests. First-class callable syntax ($this->loadClass(...)) creates a newClosureobject on each call, so the callbacks passed tospl_autoload_unregister()did not match the ones originally registered withspl_autoload_register(). As a result, autoload handlers accumulated on the SPL stack instead of being removed.Checklist: