Lock SimpleCov to < 1.1.0 to fix coveralls CI failure - #314
Merged
Conversation
SimpleCov 1.1.0 changed created_at from an integer to a float timestamp, which coveralls-ruby-adapter/coverage-reporter fails to parse (JSON::SerializableError: Couldn't parse (Int64 | Nil) from a float). This breaks the coverage workflow on every push. See coverallsapp/github-action#269 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Danger ReportWarnings
MarkdownsHere's an example of a CHANGELOG.md entry: * [#314](https://github.com/codegram/hyperclient/pull/314): Lock simplecov to < 1.1.0 to fix coveralls ci failure - [@dblock](https://github.com/dblock). |
|
Coverage is 94.7% — dblock:fix-simplecov-coveralls into codegram:master. No base build found for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SimpleCov 1.1.0 changed the
created_atfield in.resultset.jsonfrom an integer to a float timestamp.coveralls-ruby-adapter/coverage-reporterfails to parse that float, breaking thecoverageGitHub Actions workflow on every push:See coverallsapp/github-action#269 for the upstream issue and root cause.
This locks
simplecovto< 1.1.0(the last release before the regression) until coveralls fixes float-timestamp parsing.Example failing run: https://github.com/codegram/hyperclient/actions/runs/31549159260/job/93967850389