Smoss/scrape ma district pages#2145
Open
Smoss wants to merge 2 commits into
Open
Conversation
- Added functions to read district snapshots from files and strip ignored HTML tags. - Updated `parseSecDistricts` to utilize the new function for cleaning HTML input. - Introduced tests for parsing SEC snapshots in `parseSecDistricts.test.ts` to ensure correct district counts for Senate and House. - Modified the scraping script to read HTML from local files if not fetching from the web.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Smoss
requested review from
Mephistic,
alexjball,
kiminkim724,
mertbagt,
mvictor55,
nesanders,
sashamaryl and
timblais
as code owners
Mephistic
reviewed
Jun 2, 2026
Collaborator
Mephistic
left a comment
Mephistic
left a comment
There was a problem hiding this comment.
LGTM overall - just need to sync on which Legislator Profile Page to use as the base and we can merge this. Thanks for taking this on!
| memberCode: z.string() | ||
| }) | ||
|
|
||
| export default createPage<{ |
Collaborator
There was a problem hiding this comment.
I think we already have the skeleton for the legislator profile page here: https://github.com/codeforboston/maple/blob/main/pages/legislators/profile.tsx
It was added in #2113
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Scrape the https://www.sec.state.ma.us/divisions/elections/voting-information/district/2022-senatorial.htm and https://www.sec.state.ma.us/divisions/elections/voting-information/district/2022-representative.htm pages to get the districts for members.
Checklist
firestore.indexes.json(Please do not only create indexes through the Firebase Web UI, even though the error messages may reccommend it - indexes created this way may be obliterated by subsequent deploys)Screenshots
Add some screenshots highlighting your changes.
Known issues
If you've run against limitations or caveats, include them here. Include follow-up issues as well.
Steps to test/reproduce
For each feature or bug fix, create a step by step list for how a reviewer can test it out. E.g.: