fix: grant contents:write to release flow buildassets job#732
Merged
Conversation
The build_assets.yml reusable workflow now declares contents:write (needed to attach release assets via upload-release-action). A called workflow cannot request more permission than the caller grants, so release_flow.yml calling it with only contents:read caused a startup_failure. Grant contents:write on the buildassets job so the reusable workflow can compile and upload assets. Co-authored-by: Cursor <cursoragent@cursor.com>
❌ 1 Tests Failed:
View the full list of 1 ❄️ flaky test(s)
To view more test analytics, go to the Test Analytics Dashboard |
calvin-codecov
approved these changes
Jul 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Build and Publish CLI Releaseworkflow (release_flow.yml) failed withstartup_failure(e.g. run 28972104407).987d53cbumpedbuild_assets.yml's workflow-level permission tocontents: write(needed soupload-release-actioncan attach release assets viaGITHUB_TOKEN). A reusable workflow cannot request more permission than the caller grants, butrelease_flow.ymlcalls it from thebuildassetsjob with only the defaultcontents: read, so the workflow failed to compile and no jobs ran.contents: writeon thebuildassetsjob so the reusable workflow can compile and successfully upload assets.Test plan
main, then re-cut thev11.3.0release/tag so GitHub loads the corrected workflow files for therelease: createdevent.Build and Publish CLI Releaserun starts (nostartup_failure) and thebuildassetsjob uploads release assets.Made with Cursor