fix: Prevent TypeError when sendMessage resolves undefined - #161
Open
sentry[bot] wants to merge 1 commit into
Open
fix: Prevent TypeError when sendMessage resolves undefined#161sentry[bot] wants to merge 1 commit into
sentry[bot] wants to merge 1 commit into
Conversation
Bundle ReportChanges will increase total bundle size by 91 bytes (0.01%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: codecov-browser-extension-array-pushAssets Changed:
Files in
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses a
TypeError: Cannot read properties of undefined (reading 'ok')that occurs ingetComponentsandgetFlagswithinsrc/content/github/common/fetchers.ts.The root cause is that
browser.runtime.sendMessagecan resolve withundefinedwhen the background service worker's message handler (e.g.,listComponentsorlistFlags) rejects (for instance, due to a network error or unhandled exception during an API call). Chrome MV3's behavior in this scenario is to resolvesendMessagewithundefinedrather than propagating the rejection.To fix this, optional chaining (
?.ok) has been added when accessing theokproperty of theresponseobject. This ensures that ifresponseisundefined, the expression gracefully evaluates toundefined(orfalsein the ternary), preventing theTypeErrorand allowing the code to fall back to an empty array.Fixes BROWSER-EXTENSION-S9
This PR was automatically generated by Sentry. You can adjust this setting at any time.