fix: queue option ignored when group is not set#1
Open
seth-shi wants to merge 1 commit into
Open
Conversation
The `queue` option in `processOptions` was nested inside the `if (opts?.group)` block, causing it to be silently ignored whenever `group` was not provided. This meant tasks were always enqueued to the default queue regardless of the `queue` option passed. Fix: move `queue` handling into its own independent block.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
When enqueuing a task with a custom
queueoption but nogroup, the queue is silently ignored and the task always goes to the default queue.Reproduction:
Root Cause
In
composeOptions, thequeueassignment was nested inside theif (opts?.group)block:Fix
Move
queuehandling into its own independent block, separate fromgroup: