fix(security): validate FEATURE arg in check-status.sh to prevent path traversal#66
Open
xiaolai wants to merge 1 commit intocodeaholicguy:mainfrom
Open
fix(security): validate FEATURE arg in check-status.sh to prevent path traversal#66xiaolai wants to merge 1 commit intocodeaholicguy:mainfrom
xiaolai wants to merge 1 commit intocodeaholicguy:mainfrom
Conversation
…h traversal Co-Authored-By: Claude Code <noreply@anthropic.com>
This was referenced Apr 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
In
skills/dev-lifecycle/scripts/check-status.sh, theFEATUREargument (line 12) is interpolated directly into file paths likefeature-${FEATURE}.mdwithout any input validation. A maliciously crafted feature name such as../../etc/passwdor../secrets/configwould cause the script to access unintended files outside thedocs/ai/directory.While the script only performs read operations (
[[ -f ... ]]andgrep), path traversal can still leak information about the existence and content of files outside the intended scope.Fix
Added a one-line guard immediately after reading
FEATURE="$1"that rejects any feature name not matching^[a-zA-Z0-9_-]+$:This allows all valid feature names (letters, digits, hyphens, underscores) while blocking path traversal sequences. The error message tells users what format is expected.
Impact
Low severity. No code execution risk — purely a file-read path traversal guard. The fix is minimal and backwards-compatible with all valid feature name formats.