[pull] beta from TanStack:beta#70
Merged
Merged
Conversation
* fix: AppTable remounting children on table state updates (#6323) App wrappers (AppTable, AppCell, AppHeader, AppFooter) were memoized on the unstable `table` reference, causing them to be recreated every render. React then remounted their entire subtrees on every state change, destroying controlled input focus. Keep wrappers stable (created once) and read the current table from a ref updated each render. Fixes children remounting while preserving latest table state access. * also apply fix to preact * modify composable table examples to make this easier to test * update other composable table examples --------- Co-authored-by: Kevin Van Cott <kevinvandy656@gmail.com>
release: v9.0.0-beta.13 Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
* fix: enhance table option merging to preserve static properties Updated the table_mergeOptions function to ensure that static options (features, atoms, initialState) are preserved without mutation when merging new options. Added a test to verify that static options remain unchanged after invoking setOptions. * add short circuit
release: v9.0.0-beta.14 Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…emoves array filter values (#6332) fix(table-core): fix filterFn_between/betweenInclusive autoRemove never removing array filter values filterFn_between and filterFn_betweenInclusive had `autoRemove: (val: any) => !val`. Since any array is truthy in JavaScript, `!val` is always `false` for the `[min, max]` tuple these filters receive, meaning the filter is NEVER auto-removed — even when both endpoints are empty strings, null, or undefined. A user who clears both range inputs ends up with an active filter that passes all rows but can never be auto-removed from column filter state. Fix: align with the same pattern used by filterFn_inNumberRange: autoRemove: (val) => testFalsy(val) || (testFalsy(val[0]) && testFalsy(val[1])) This correctly removes the filter when both endpoints are falsy (undefined, null, or empty string) while preserving 0 as a valid endpoint value. Fixes: filterFns.between and filterFns.betweenInclusive auto-remove logic Co-authored-by: JSap0914 <JSap0914@users.noreply.github.com>
release: v9.0.0-beta.15 Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )