[pull] beta from TanStack:beta#112
Merged
Merged
Conversation
* feat: batch row selection * fix tests * pr feedback and add migration guide note * no more e2e in pr * fix angular examples double building in ci tests * fix type
release: v9.0.0-beta.44 Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Clarify column visibility toggle labels Column visibility menus render column objects, not active header objects, so rendering columnDef.header directly can fail or confuse users when headers are JSX/templates or when columns are hidden. The guide now shows a stable label map fallback and calls out flexRender as the correct path for real header rendering. Related: #5751 Confidence: high Scope-risk: narrow Tested: pnpm prettier --write docs/framework/react/guide/column-visibility.md; pnpm test:docs Not-tested: Full repository test suite
Auto page-index resets should return to the feature default first page when row-model-affecting state changes. Calling table_resetPageIndex without defaultState preserved initialState.pagination.pageIndex, which could leave the table on a stale non-zero page after filtering, sorting, grouping, or data updates. Constraint: resetPageIndex() without arguments intentionally restores initial state, so the fix is scoped to the automatic reset path only. Rejected: Change table_resetPageIndex default behavior | public reset API semantics depend on restoring initial state. Confidence: high Scope-risk: narrow Directive: Keep manual reset API behavior separate from automatic row-model reset behavior. Tested: pnpm vitest run packages/table-core/tests/unit/features/row-pagination/rowPaginationFeature.utils.test.ts Tested: pnpm nx run @tanstack/table-core:test:lib Not-tested: Full monorepo test:ci Related: #6207
release: v9.0.0-beta.45 Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…ter autoRemove (#6394) * fix(table-core): guard Array.isArray before index access in range filter autoRemove `filterFn_between`, `filterFn_betweenInclusive`, and `filterFn_inNumberRange` shared an `autoRemove` that did `testFalsy(val[0]) && testFalsy(val[1])`. When a scalar value such as `99` was passed instead of a `[min, max]` tuple, `val[0]` and `val[1]` were both `undefined`, so the condition evaluated to `true && true` and the filter was silently auto-removed. Numeric columns default to `inNumberRange` via `column_getAutoFilterFn`, so calling `col.setColumnFilter(99)` on a numeric column discarded the filter before the row scan even ran. Wrap the index checks in `Array.isArray(val) &&`. The leading `testFalsy(val)` still handles `undefined`, `null`, `0`, and `''`. Behavior of the existing array-tuple cases is unchanged because `Array.isArray` is true and short-circuits to the same boolean. Closes #6353 * test(filterFns): assert empty-string scalar IS auto-removed The previous regression test for #6353 bundled the non-empty scalar case (autoRemove(99) and autoRemove(0)) with an empty-string expectation (autoRemove('')). testFalsy treats '' as falsy, so the leading testFalsy(val) branch correctly returns true for '' - the Array.isArray guard added in 0041efb is intentionally additive and not meant to override that behavior. Split the assertion: the non-empty scalar test now stands alone with just autoRemove(99) and autoRemove(0); the empty-string behavior is covered by a separate explicit assertion (expect(autoRemove(''))).toBe(true)) Vitest run: Test Files 1 passed (1) Tests 73 passed (73) Signed-off-by: sanjibani <18418553+sanjibani@users.noreply.github.com> --------- Signed-off-by: sanjibani <18418553+sanjibani@users.noreply.github.com> Co-authored-by: sanjibani <18418553+sanjibani@users.noreply.github.com> Co-authored-by: JSap0914
release: v9.0.0-beta.46 Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )