Skip to content

[pull] dev from mrdoob:dev #1241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pull merged 3 commits into from
Mar 29, 2026
Merged

[pull] dev from mrdoob:dev #1241

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7a77bfe
Fix: preserve multiview in RenderTarget.copy() (#33285)
Kundan-CR7 Mar 29, 2026
859402c
Update NormalMapNode.js
Mugen87 Mar 29, 2026
4dca825
Update WebGLRenderer.js
Mugen87 Mar 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/core/RenderTarget.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -369,6 +369,7 @@ class RenderTarget extends EventDispatcher {
if ( source.depthTexture !== null ) this.depthTexture = source.depthTexture.clone();

this.samples = source.samples;
this.multiview = source.multiview;

return this;

Expand Down
4 changes: 2 additions & 2 deletions src/nodes/display/NormalMapNode.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,15 +87,15 @@ class NormalMapNode extends TempNode {

} else if ( unpackNormalMode !== NoNormalPacking ) {

console.error( `THREE.NodeMaterial: Unexpected unpack normal mode: ${ unpackNormalMode }` );
error( `THREE.NodeMaterial: Unexpected unpack normal mode: ${ unpackNormalMode }` );

}

} else {

if ( unpackNormalMode !== NoNormalPacking ) {

console.error( `THREE.NodeMaterial: Normal map type '${ normalMapType }' is not compatible with unpack normal mode '${ unpackNormalMode }'` );
error( `THREE.NodeMaterial: Normal map type '${ normalMapType }' is not compatible with unpack normal mode '${ unpackNormalMode }'` );

}

Expand Down
4 changes: 2 additions & 2 deletions src/renderers/WebGLRenderer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -727,7 +727,7 @@ class WebGLRenderer {

if ( _outputBufferType === UnsignedByteType ) {

console.error( 'THREE.WebGLRenderer: setEffects() requires outputBufferType set to HalfFloatType or FloatType.' );
error( 'THREE.WebGLRenderer: setEffects() requires outputBufferType set to HalfFloatType or FloatType.' );
return;

}
Expand All @@ -738,7 +738,7 @@ class WebGLRenderer {

if ( effects[ i ].isOutputPass === true ) {

console.warn( 'THREE.WebGLRenderer: OutputPass is not needed in setEffects(). Tone mapping and color space conversion are applied automatically.' );
warn( 'THREE.WebGLRenderer: OutputPass is not needed in setEffects(). Tone mapping and color space conversion are applied automatically.' );
break;

}
Expand Down
Loading