Skip to content

[pull] dev from mrdoob:dev #1227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pull merged 1 commit into from
Mar 24, 2026
Merged

[pull] dev from mrdoob:dev #1227

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion examples/webgpu_postprocessing_dof_basic.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@
const hdrLoader = new UltraHDRLoader();
const envMap = await hdrLoader.loadAsync( 'textures/equirectangular/spruit_sunrise_2k.hdr.jpg' );
envMap.mapping = THREE.EquirectangularReflectionMapping;
scene.environmentRotation.y = Math.PI * 0.5;
scene.environmentRotation.y = Math.PI * - 0.5;
scene.environment = envMap;

// renderer
Expand Down
8 changes: 7 additions & 1 deletion src/nodes/accessors/CubeTextureNode.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,13 +124,19 @@ class CubeTextureNode extends TextureNode {

}

// rotate first

uvNode = materialEnvRotation.mul( uvNode );

// flip

if ( builder.renderer.coordinateSystem === WebGPUCoordinateSystem || ! texture.isRenderTargetTexture ) {

uvNode = vec3( uvNode.x.negate(), uvNode.yz );

}

return materialEnvRotation.mul( uvNode );
return uvNode;

}

Expand Down
7 changes: 2 additions & 5 deletions src/nodes/accessors/MaterialProperties.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
import { Euler } from '../../math/Euler.js';
import { Matrix4 } from '../../math/Matrix4.js';
import { uniform } from '../core/UniformNode.js';

const _e1 = /*@__PURE__*/ new Euler();
const _m1 = /*@__PURE__*/ new Matrix4();

/**
Expand Down Expand Up @@ -44,9 +42,8 @@ export const materialEnvRotation = /*@__PURE__*/ uniform( new Matrix4() ).onRefe

if ( rotation ) {

_e1.copy( rotation );

_m1.makeRotationFromEuler( _e1 );
// note: since the matrix is orthonormal, we can use the more-efficient transpose() in lieu of invert()
_m1.makeRotationFromEuler( rotation ).transpose();

} else {

Expand Down
10 changes: 2 additions & 8 deletions src/nodes/accessors/SceneProperties.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,8 @@
import { UVMapping } from '../../constants.js';
import { Euler } from '../../math/Euler.js';
import { Matrix4 } from '../../math/Matrix4.js';
import { renderGroup } from '../core/UniformGroupNode.js';
import { uniform } from '../tsl/TSLBase.js';

const _e1 = /*@__PURE__*/ new Euler();
const _m1 = /*@__PURE__*/ new Matrix4();

/**
Expand Down Expand Up @@ -35,12 +33,8 @@ export const backgroundRotation = /*@__PURE__*/ uniform( new Matrix4() ).setGrou

if ( background !== null && background.isTexture && background.mapping !== UVMapping ) {

_e1.copy( scene.backgroundRotation );

// accommodate left-handed frame
_e1.x *= - 1; _e1.y *= - 1; _e1.z *= - 1;

_m1.makeRotationFromEuler( _e1 );
// note: since the matrix is orthonormal, we can use the more-efficient transpose() in lieu of invert()
_m1.makeRotationFromEuler( scene.backgroundRotation ).transpose();

} else {

Expand Down
Loading